Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function

From	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function
Date	2016-01-13 11:20 +0100
Message-ID	<qQqGZ-6FS-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <qQ8TM-2LK-29@gated-at.bofh.it> <qQoFd-5eg-27@gated-at.bofh.it> <qQoOS-5ih-21@gated-at.bofh.it> <qQpUD-63W-9@gated-at.bofh.it> <qQq4j-68Z-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-01-13 at 10:33 +0100, Christoph Hellwig wrote:
> On Wed, Jan 13, 2016 at 01:22:49AM -0800, Nicholas A. Bellinger wrote:
> > Huh..?  It's used by iscsi-target, ib_isert, tcm_qla2xxx, vhost-scsi and
> > tcm_fc.
> > 
> > That's the majority of the drivers people care about.
> 
> ib_isert never calls transport_init_session / transport_init_session_tags
> directly.
> 

Yes.

Not to mention, there is a new struct iscsit_transport based driver on
the way that assumes percpu-ida tag preallocation using this same
method.

> We've got 3 callers to transport_init_session_tags vs 6 to
> transport_init_session.
> 

In that case, I'll look into converting sbp-target, usb-gadget and
xen-scsiback to use percpu-ida like the other consumers here for v4.6
code. 

> iSCSI already works roughly the way I suggest everything should
> work in the future - it uses transport_init_session but manually
> allocates the tags.

iscsi-target needs it open-coded for discovery purposes, because
se_node_acl lookup does not occur.

However for the normal session login se_node_acl lookup back, I don't
see a reason why iscsi-target can't use target_alloc_session() here too.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@daterainc.com> - 2016-01-10 21:50 +0100
  Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-12 16:20 +0100
    Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 09:10 +0100
      Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-13 09:20 +0100
        Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 10:30 +0100
          Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-13 10:40 +0100
            Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 11:20 +0100

csiph-web