Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308154

Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function
Date 2016-01-13 09:20 +0100
Message-ID <qQoOS-5ih-21@gated-at.bofh.it> (permalink)
References <qPv62-Kq-3@gated-at.bofh.it> <qPv61-Kq-1@gated-at.bofh.it> <qQ8TM-2LK-29@gated-at.bofh.it> <qQoFd-5eg-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 13, 2016 at 12:09:26AM -0800, Nicholas A. Bellinger wrote:
> > I'd much rather have the fabrics drivers call transport_alloc_session_tags
> > directly from the callback than growing even more arguments here.
> > 
> 
> What's the point..?
> 
> Only vhost-scsi currently needs to allocate extra resources for
> se_session percpu-ida tag pre-allocation.

The point is that allocating "tags" (or better command structures) isn't
fundamentally related to allocating a session, and in fact not even
used by many drivers.  A flow where drivers that need these "tags"
explicitly allocate them is a lot more obvious than forcing more
arguments to a function that already has a lot and isn't related to
these "tags" otherwise.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@daterainc.com> - 2016-01-10 21:50 +0100
  Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-12 16:20 +0100
    Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 09:10 +0100
      Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-13 09:20 +0100
        Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 10:30 +0100
          Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function Christoph Hellwig <hch@lst.de> - 2016-01-13 10:40 +0100
            Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper  function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 11:20 +0100

csiph-web