Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024
Date	2016-01-13 11:20 +0100
Message-ID	<qQqGZ-6FS-9@gated-at.bofh.it> (permalink)
References	<qQ3r4-7nB-9@gated-at.bofh.it> <qQ3r4-7nB-7@gated-at.bofh.it> <qQhNn-gY-1@gated-at.bofh.it> <qQpKX-60h-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 13/01/2016 at 14:30:26 +0530, Laxman Dewangan wrote :
> In my 3rd patch, I tried to align it little more where is possible. But I
> feel that all these indenting is more over individual choice. Example, I
> added one more indent in below example to look better.
> 
> 
>         ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE,
> -               MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
> -               MAX77620_ONOFFCNFG2_WK_EN0);
> +                       MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
> +                       MAX77620_ONOFFCNFG2_WK_EN0);
> 
> 

You should probably use checkpatch.pl --strict, it requires that you
align on the open parenthesis.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/6] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
  [PATCH V2 4/6] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
  [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
    Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:10 +0100
      Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 05:20 +0100
        Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 05:30 +0100
          Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 05:40 +0100
            Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 16:20 +0100
              Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-14 02:00 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-14 02:30 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-14 13:10 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-15 03:00 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Mark Brown <broonie@kernel.org> - 2016-01-14 15:30 +0100
  Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:50 +0100
    Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 10:20 +0100
      Re: [PATCH V2 2/6] mfd: max77620: add core driver for  MAX77620/MAX20024 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-13 11:20 +0100

csiph-web