Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308146
| From | "Nicholas A. Bellinger" <nab@linux-iscsi.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function |
| Date | 2016-01-13 09:10 +0100 |
| Message-ID | <qQoFd-5eg-27@gated-at.bofh.it> (permalink) |
| References | <qPv62-Kq-3@gated-at.bofh.it> <qPv61-Kq-1@gated-at.bofh.it> <qQ8TM-2LK-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-01-12 at 16:11 +0100, Christoph Hellwig wrote:
> > +struct se_session *
> > +target_alloc_session(struct se_portal_group *tpg,
> > + unsigned int tag_num, unsigned int tag_size,
> > + enum target_prot_op prot_op,
> > + const char *initiatorname, void *private,
> > + int (*callback)(struct se_portal_group *,
> > + struct se_session *, void *))
> > +{
>
> I'd much rather have the fabrics drivers call transport_alloc_session_tags
> directly from the callback than growing even more arguments here.
>
What's the point..?
Only vhost-scsi currently needs to allocate extra resources for
se_session percpu-ida tag pre-allocation.
The rest of the consumers can just use this common code.
> > + struct se_session *sess;
> > +
> > + if (tag_num != 0 && !tag_size) {
> > + pr_err("target_alloc_session called with percpu-ida tag_num:"
> > + " %u, but zero tag_size\n", tag_num);
> > + return ERR_PTR(-EINVAL);
> > + }
> > + if (!tag_num && tag_size) {
> > + pr_err("target_alloc_session called with percpu-ida tag_size:"
> > + " %u, but zero tag_num\n", tag_size);
> > + return ERR_PTR(-EINVAL);
> > + }
>
> These checks should be in transport_alloc_session_tags.
>
Done.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@daterainc.com> - 2016-01-10 21:50 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function Christoph Hellwig <hch@lst.de> - 2016-01-12 16:20 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 09:10 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function Christoph Hellwig <hch@lst.de> - 2016-01-13 09:20 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 10:30 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function Christoph Hellwig <hch@lst.de> - 2016-01-13 10:40 +0100
Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-01-13 11:20 +0100
csiph-web