Re: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation
Date	2016-01-13 09:20 +0100
Message-ID	<qQoOS-5ih-19@gated-at.bofh.it> (permalink)
References	<qQo2u-4Jn-7@gated-at.bofh.it> <qQo2u-4Jn-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 13 Jan 2016 16:19:52 +0900
Milo Kim <milo.kim@ti.com> wrote:

> AIC5 priority value is updated twice -
> in aic_common_set_priority() and when updating AT91_AIC5_SMR.
> Variable, 'smr' has updated priority value (intspec[2]) in the first step,
> so no need to update it again in the second step.
> 
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> Cc: Nicholas Ferre <nicolas.ferre@atmel.com>
> Cc: linux-kernel@vger.kernel.org

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

> ---
>  drivers/irqchip/irq-atmel-aic5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c
> index f36f426..4f0d068 100644
> --- a/drivers/irqchip/irq-atmel-aic5.c
> +++ b/drivers/irqchip/irq-atmel-aic5.c
> @@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d,
>  	irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR);
>  	smr = irq_reg_readl(bgc, AT91_AIC5_SMR);
>  	aic_common_set_priority(intspec[2], &smr);
> -	irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR);
> +	irq_reg_writel(bgc, smr, AT91_AIC5_SMR);
>  	irq_gc_unlock(bgc);
>  
>  	return ret;



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] irqchip: atmel-aic: Handle aic_common_irq_fixup in aic_common_of_init Milo Kim <milo.kim@ti.com> - 2016-01-13 08:30 +0100
  [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation Milo Kim <milo.kim@ti.com> - 2016-01-13 08:30 +0100
    Re: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-01-13 09:20 +0100

csiph-web