Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308147

Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out

Show all headers | View raw

Heiko,

在 2016年01月08日 17:46, Heiko Stuebner 写道:
> Hi Caesar,
>
> Am Freitag, 8. Januar 2016, 17:26:18 schrieb Caesar Wang:
>> 在 2016年01月07日 18:05, Heiko Stuebner 写道:
>>> Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang:
>>>> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by
>>>> extra codecs.
>>>>
>>>> Due to it shouldn't belong to any driver, but we need it enabled,
>>>> so just mark it as the CLK_IGNORE_UNUSED flag.
>>> What makes you think it shouldn't belong to any driver?
>>>
>>> In most schematics I have, i2s_clkout is going to some clock-input of
>>> the
>>> audio codec - probably the MCLK input on your rt5616. And while the new
>>> rt5616 driver does not seem to do clock handling, it should just handle
>>> the clock using the normal APIs.
>> You are right,  that's seem has to find the root cause.
>> I'm wonder that the codec/i2s is working in kernel v4.1 patch without it.
>>
>> In general,  the MLCK will be handled in i2s driver if the cpu side is
>> master.
> looking at the rt5616 datasheet, that would be BCLK1 instead I think. This
> one does differentiate between being master/slave.
>
> The master/sysclk (mclk) is also handled in other drivers in all cases.
> (da7213.c, da7219.c, max98090.c, max98095.c, probably more)

Saw the patch:
https://patchwork.kernel.org/patch/5427131/

Add the follow that's working.

--- a/arch/arm/boot/dts/rk3036.dtsi
+++ b/arch/arm/boot/dts/rk3036.dtsi
@@ -288,8 +288,8 @@
                 interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
                 #address-cells = <1>;
                 #size-cells = <0>;
-               clock-names = "i2s_clk", "i2s_hclk";
-               clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>;
+               clock-names = "i2s_clk", "i2s_hclk", "i2s_clk_out";
+               clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>, <&cru 
SCLK_I2S_OUT>;

Okay, I believe Mark likes that works in codec driver.

>
>
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
Thanks,
Caesar

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:20 +0100
  [PATCH v2 09/12] ARM: dts: rockchip: enable the uart0 for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 11/12] ARM: dts: rockchip: add the lcdc and hdmi node for rk3036 Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 13:30 +0100
      Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:50 +0100
        Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:10 +0100
          Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Caesar Wang <caesar.upstream@gmail.com> - 2016-01-15 10:20 +0100
  [PATCH v2 12/12] ARM: dts: Add pl330-broken-no-flushp quirk for rk3036 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:40 +0100
      Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s  for kylin board Caesar Wang <caesar.upstream@gmail.com> - 2016-01-11 14:40 +0100
  [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Heiko Stuebner <heiko@sntech.de> - 2016-01-07 11:10 +0100
      Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the  CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <caesar.upstream@gmail.com> - 2016-01-08 10:30 +0100
        Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Heiko Stuebner <heiko@sntech.de> - 2016-01-08 10:50 +0100
          Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the  CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <caesar.upstream@gmail.com> - 2016-01-13 09:20 +0100
  [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for the simple power sequence Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for  the simple power sequence Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 13:20 +0100
  [PATCH v2 07/12] ARM: dts: rockchip: enable the high speed on sdio for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 10/12] ARM: dts: rockchip: add the sdmmc for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  Re: [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner <heiko@sntech.de> - 2016-01-07 11:50 +0100

csiph-web