Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver

Path	csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver
Date	Thu, 17 Dec 2015 01:40:02 +0100
Message-ID	<qGuLU-ws-17@gated-at.bofh.it> (permalink)
References	<qG5DP-1iE-11@gated-at.bofh.it> <qG5DQ-1iE-13@gated-at.bofh.it> <qG6gy-1N2-5@gated-at.bofh.it> <qG7FE-2zx-1@gated-at.bofh.it> <qG7Pk-2RZ-7@gated-at.bofh.it> <qG8BJ-3aD-27@gated-at.bofh.it> <qG94K-3zE-3@gated-at.bofh.it> <qG94K-3zE-19@gated-at.bofh.it> <qGhbX-ou-19@gated-at.bofh.it>
X-Original-To	Ulf Hansson <ulf.hansson@linaro.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	Sebastian Reichel <sre@ring0.de>, Mark Rutland <mark.rutland@arm.com>, "devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Alexander Aring <alex.aring@gmail.com>, Pawel Moll <pawel.moll@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-pm\@vger.kernel.org" <linux-pm@vger.kernel.org>, Lee Jones <lee@kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>, Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, linux-rpi-kernel@lists.infradead.org, Ian Campbell <ijc+devicetree@hellion.org.uk>, "linux-arm-kernel\@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Wed, 16 Dec 2015 16:39:26 -0800
X-Original-Message-ID	<87zix9rjr5.fsf@eliezer.anholt.net>
X-Original-References	<1450215622-27394-1-git-send-email-eric@anholt.net> <1450215622-27394-3-git-send-email-eric@anholt.net> <567093CD.1020208@gmail.com> <87oadrmfmi.fsf@eliezer.anholt.net> <5670AAB2.1080102@gmail.com> <87mvtbkyd0.fsf@eliezer.anholt.net> <20151216011110.GA13147@earth> <CAJKOXPes85hu6Jnd5p6dqhgdBGF4kmZuJQekM73O83DuZvcyoQ@mail.gmail.com> <CAPDyKFqPk5XPPYMYe6HZc=b8-b-Y2VB6mQfZP8_TS8KOFZjsUw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1293427

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 16 December 2015 at 02:27, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> 2015-12-16 10:11 GMT+09:00 Sebastian Reichel <sre@ring0.de>:
>>> Hi,
>>>
>>> On Tue, Dec 15, 2015 at 04:53:31PM -0800, Eric Anholt wrote:
>>>> >> There are 6 power domain drivers in
>>>> >> arch/arm, 3 in drivers/clk, and 3 in drivers/soc.
>>>> >
>>>> > If we ever have to support a different architecture which happens to use
>>>> > a similar power domain, then we want it to be in a location which makes
>>>> > it easy for sharing it in the first place. As it stands today, it does
>>>> > not seem useful to me to have this code in arch/arm/mach-bcm/ at all.
>>>> >
>>>> > Maybe there is room from a drivers/power/domains/ of some kind?
>>>
>>> I like the idea, but let's include generic power domain maintainers
>>> in this discussion, as I suggested here (I got a power domain driver
>>> patch for drivers/power just a few days ago):
>>>
>>> https://lkml.org/lkml/2015/12/15/815
>>>
>>> Also somebody would have to step up to maintain that directory.
>>
>> This could go into drivers/soc. We put there a lot of mach-specific
>> stuff which we want to make a little more generic (like generic enough
>> multiplatform, multiarchitecture etc). Rockchip has its own power
>> domains there. Dove and Mediatek seem as well but I am not sure. Some
>> other architectures keep this still in arm/mach (exynos, ux500, zx,
>> imx, s34c64xx, shmobile) but this looks more of like a legacy choice.
>
> Agree, drivers/soc is good.

OK, I've resent with a move to drivers/soc/bcm/.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-15 22:50 +0100
  Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Florian Fainelli <f.fainelli@gmail.com> - 2015-12-15 23:30 +0100
    Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-16 01:00 +0100
      Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Florian Fainelli <f.fainelli@gmail.com> - 2015-12-16 01:10 +0100
        Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-16 02:00 +0100
          Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Sebastian Reichel <sre@ring0.de> - 2015-12-16 02:30 +0100
            Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-16 02:30 +0100
              Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-16 11:10 +0100
                Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-17 01:40 +0100

csiph-web