Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1292654
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver |
| Date | 2015-12-16 01:00 +0100 |
| Message-ID | <qG7FE-2zx-1@gated-at.bofh.it> (permalink) |
| References | <qG5DP-1iE-11@gated-at.bofh.it> <qG5DQ-1iE-13@gated-at.bofh.it> <qG6gy-1N2-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Florian Fainelli <f.fainelli@gmail.com> writes: > On 15/12/15 13:40, Eric Anholt wrote: >> From: Alexander Aring <alex.aring@gmail.com> >> >> This patch adds support for several power domains on Raspberry Pi, >> including USB (so it can be enabled even if the bootloader didn't do >> it), and graphics. >> >> This patch is the combined work of Eric Anholt (who wrote USB support >> inside of the Raspberry Pi firmware driver, and wrote the non-USB >> domain support) and Alexander Aring (who separated the original USB >> work out from the firmware driver). >> >> Signed-off-by: Alexander Aring <alex.aring@gmail.com> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- >> >> v2: Add support for power domains other than USB, using the new >> firmware interface, reword commit message (changes by Eric) >> >> v3: Restructure as a builtin driver, and drop >> of_genpd_add_provider_onecell error handling to avoid >> pm_genpd_exit() dependency until that API can be settled. Clean >> up copyright header, add missing ISP initialization, and fix typo >> in transposer's name. >> >> arch/arm/mach-bcm/Kconfig | 10 ++ >> arch/arm/mach-bcm/Makefile | 1 + >> arch/arm/mach-bcm/raspberrypi-power.c | 247 ++++++++++++++++++++++++++++ >> include/dt-bindings/arm/raspberrypi-power.h | 41 +++++ >> 4 files changed, 299 insertions(+) >> create mode 100644 arch/arm/mach-bcm/raspberrypi-power.c > > What motivated the location of this power domain driver in > arch/arm/mach-bcm? Should not we have this in drivers/power/ or > somewhere in drivers/ at the very least? ls stronly suggests that power contains drivers for power supplies and batteries, not power domains. There are 6 power domain drivers in arch/arm, 3 in drivers/clk, and 3 in drivers/soc.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-15 22:50 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Florian Fainelli <f.fainelli@gmail.com> - 2015-12-15 23:30 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-16 01:00 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Florian Fainelli <f.fainelli@gmail.com> - 2015-12-16 01:10 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-16 02:00 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Sebastian Reichel <sre@ring0.de> - 2015-12-16 02:30 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-16 02:30 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-16 11:10 +0100
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-17 01:40 +0100
csiph-web