Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280143

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation
Date 2015-11-30 19:00 +0100
Message-ID <qAAU2-6Ky-17@gated-at.bofh.it> (permalink)
References <qz7Kq-7Fr-23@gated-at.bofh.it> <qzmzL-lM-1@gated-at.bofh.it> <qzP8K-1HY-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote:
> atl1c driver is doing order-4 allocation with GFP_ATOMIC
> priority. That often breaks  networking after resume. Switch to
> GFP_KERNEL. Still not ideal, but should be significantly better.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 2795d6d..afb71e0 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -1016,10 +1016,10 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter)
>  		sizeof(struct atl1c_recv_ret_status) * rx_desc_count +
>  		8 * 4;
>  
> -	ring_header->desc = pci_alloc_consistent(pdev, ring_header->size,
> -				&ring_header->dma);
> +	ring_header->desc = dma_alloc_coherent(&pdev->dev, ring_header->size,
> +					       &ring_header->dma, GFP_KERNEL);
>  	if (unlikely(!ring_header->desc)) {
> -		dev_err(&pdev->dev, "pci_alloc_consistend failed\n");
> +		dev_err(&pdev->dev, "could not get memmory for DMA buffer\n");
>  		goto err_nomem;
>  	}
>  	memset(ring_header->desc, 0, ring_header->size);
> 

It seems there is a missed opportunity to get rid of the memset() here,
by adding __GFP_ZERO to the dma_alloc_coherent() GFP_KERNEL mask,
or simply using dma_zalloc_coherent()





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

4.3+: Atheros ethernet fails after resume from s2ram, due to order 4  allocation Pavel Machek <pavel@ucw.cz> - 2015-11-26 17:40 +0100
  Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Francois Romieu <romieu@fr.zoreil.com> - 2015-11-26 23:00 +0100
  Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Michal Hocko <mhocko@kernel.org> - 2015-11-27 09:30 +0100
    [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-11-28 16:00 +0100
      Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-29 23:00 +0100
      Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Michal Hocko <mhocko@kernel.org> - 2015-11-30 14:30 +0100
        Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation David Miller <davem@davemloft.net> - 2015-12-01 21:40 +0100
          Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Pavel Machek <pavel@ucw.cz> - 2015-12-03 08:50 +0100
          Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Michal Hocko <mhocko@kernel.org> - 2015-12-03 09:20 +0100
      Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-30 19:00 +0100
        Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation David Miller <davem@davemloft.net> - 2015-12-01 21:40 +0100
          Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Pavel Machek <pavel@ucw.cz> - 2015-12-03 17:00 +0100
      [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-03 17:00 +0100
        Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Michal Hocko <mhocko@kernel.org> - 2015-12-03 17:20 +0100
        Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-03 18:20 +0100
          Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-03 18:40 +0100
            Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 09:20 +0100
              Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-04 17:30 +0100
                Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 22:40 +0100
                Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-04 23:10 +0100
        [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 10:00 +0100
    Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Pavel Machek <pavel@ucw.cz> - 2015-11-28 16:00 +0100

csiph-web