Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279427

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

Show all headers | View raw

Hello.

On 11/28/2015 5:51 PM, Pavel Machek wrote:

> atl1c driver is doing order-4 allocation with GFP_ATOMIC
> priority. That often breaks  networking after resume. Switch to
> GFP_KERNEL. Still not ideal, but should be significantly better.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 2795d6d..afb71e0 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -1016,10 +1016,10 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter)
>   		sizeof(struct atl1c_recv_ret_status) * rx_desc_count +
>   		8 * 4;
>
> -	ring_header->desc = pci_alloc_consistent(pdev, ring_header->size,
> -				&ring_header->dma);
> +	ring_header->desc = dma_alloc_coherent(&pdev->dev, ring_header->size,
> +					       &ring_header->dma, GFP_KERNEL);
>   	if (unlikely(!ring_header->desc)) {
> -		dev_err(&pdev->dev, "pci_alloc_consistend failed\n");
> +		dev_err(&pdev->dev, "could not get memmory for DMA buffer\n");

     s/memmory/memory/.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

4.3+: Atheros ethernet fails after resume from s2ram, due to order 4  allocation Pavel Machek <pavel@ucw.cz> - 2015-11-26 17:40 +0100
  Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Francois Romieu <romieu@fr.zoreil.com> - 2015-11-26 23:00 +0100
  Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Michal Hocko <mhocko@kernel.org> - 2015-11-27 09:30 +0100
    [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-11-28 16:00 +0100
      Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-29 23:00 +0100
      Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Michal Hocko <mhocko@kernel.org> - 2015-11-30 14:30 +0100
    Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to  order 4 allocation Pavel Machek <pavel@ucw.cz> - 2015-11-28 16:00 +0100

csiph-web