Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation
Date	2015-12-04 22:40 +0100
Message-ID	<qC6f7-88D-1@gated-at.bofh.it> (permalink)
References	<qBFHY-83M-17@gated-at.bofh.it> <qBG1k-8ar-9@gated-at.bofh.it> <qBTKV-aS-1@gated-at.bofh.it> <qC1pa-54b-73@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 2015-12-04 11:21:40, David Miller wrote:
> From: Pavel Machek <pavel@ucw.cz>
> Date: Fri, 4 Dec 2015 09:11:27 +0100
> 
> >> >>  	if (unlikely(!ring_header->desc)) {
> >> >> -		dev_err(&pdev->dev, "pci_alloc_consistend failed\n");
> >> >> +		dev_err(&pdev->dev, "could not get memory for DMA buffer\n");
> >> >>  		goto err_nomem;
> >> >>  	}
> >> >>  	memset(ring_header->desc, 0, ring_header->size);
> >> >> 
> >> >> 
> >> > 
> >> > So this memset() will really require a different patch to get removed ?
> >> > 
> >> > Sigh, not sure why I review patches.
> >> 
> >> Agreed, please use dma_zalloc_coherent() and kill that memset().
> > 
> > Ok, updated. I'll also add cc: stable, because it makes notebooks with
> > affected chipset unusable.
> 
> Networking patches do not use CC: stable, instead you simply ask me
> to queue it up and then I batch submit networking fixes to -stable
> periodically myself.

Ok, can you take the patch and ignore the Cc, or should I do one more
iteration?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-03 17:00 +0100
  Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Michal Hocko <mhocko@kernel.org> - 2015-12-03 17:20 +0100
  Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-03 18:20 +0100
    Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-03 18:40 +0100
      Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 09:20 +0100
        Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-04 17:30 +0100
          Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 22:40 +0100
            Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation David Miller <davem@davemloft.net> - 2015-12-04 23:10 +0100
  [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC  allocation Pavel Machek <pavel@ucw.cz> - 2015-12-04 10:00 +0100

csiph-web