Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation
Date	2015-12-03 09:20 +0100
Message-ID	<qBxho-2o6-25@gated-at.bofh.it> (permalink)
References	<qzmzL-lM-1@gated-at.bofh.it> <qzP8K-1HY-11@gated-at.bofh.it> <qAwGK-4aw-15@gated-at.bofh.it> <qAZSq-622-19@gated-at.bofh.it> <qBwOl-1XG-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 02-12-15 22:43:31, Chris Snook wrote:
> On Tue, Dec 1, 2015 at 12:35 PM David Miller <davem@davemloft.net> wrote:
> 
> > From: Michal Hocko <mhocko@kernel.org>
> > Date: Mon, 30 Nov 2015 14:21:29 +0100
> >
> > > On Sat 28-11-15 15:51:13, Pavel Machek wrote:
> > >>
> > >> atl1c driver is doing order-4 allocation with GFP_ATOMIC
> > >> priority. That often breaks  networking after resume. Switch to
> > >> GFP_KERNEL. Still not ideal, but should be significantly better.
> > >
> > > It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither
> > > from the changelog nor from the patch context.
> >
> > Earlier in the function we do a GFP_KERNEL kmalloc so:
> >
> > ¯\_(ツ)_/¯
> >
> > It should be fine.
> >
> 
> AFAICT, the people who benefit from GFP_ATOMIC are the people running all
> their storage over NFS/iSCSI who are suspending their machines while
> they're so busy they don't have any clean order 4 pagecache to drop, and
> want the machine to panic rather than hang.

Why would GFP_KERNEL order-4 allocation hang? It will fail if there are
not >=4 order pages available even after reclaim and/or compaction.
GFP_ATOMIC allocations should be used only when an access to memory
reserves is really required. If the allocation just doesn't want to
invoke direct reclaim then GFP_NOWAIT is a more suitable alternative.

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation David Miller <davem@davemloft.net> - 2015-12-01 21:40 +0100
  Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Pavel Machek <pavel@ucw.cz> - 2015-12-03 08:50 +0100
  Re: [PATCH] Improve Atheros ethernet driver not to do order 4  GFP_ATOMIC allocation Michal Hocko <mhocko@kernel.org> - 2015-12-03 09:20 +0100

csiph-web