Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204358

Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios

From Mike Snitzer <snitzer@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date 2015-08-10 17:10 +0200
Message-ID <pVWS5-1tl-9@gated-at.bofh.it> (permalink)
References (5 earlier) <pVrXX-5Ro-5@gated-at.bofh.it> <pVsAF-6A9-3@gated-at.bofh.it> <pVsKm-6Lu-3@gated-at.bofh.it> <pVsU2-7cA-7@gated-at.bofh.it> <pVt3I-7nX-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 09 2015 at  3:18am -0400,
Ming Lin <mlin@kernel.org> wrote:

> On Sun, 2015-08-09 at 00:01 -0700, Christoph Hellwig wrote:
> > On Sat, Aug 08, 2015 at 11:55:47PM -0700, Ming Lin wrote:
> > > Will change it to MAX_BIO_SECTORS.
> > > May I add your ACK?
> > 
> > Yes, please go ahead.
> 
> Thanks. I'll send a new version of the series once device-mapper guy
> acks.
> 
> Hi Mike,
> 
> I have updated my tree. Could you pull and re-test?
> https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=block-generic-req
> 
> The 2 thin-provisioning tests passed.

I've merged your latest branch with my dm-4.3 branch, I had one conflict
in the merge due to the dm_merge_bvec() change from 4.2-rc6 (no
surprise).  I've published the result here:
http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=block-late-bio-splitting

It passes the device-mapper-test-suite's 'thin-provisioning' tests.

> Hope I can have your ACK soon.

Shouldn't we also be using MAX_BIO_SECTORS in blkdev_issue_write_same
(instead of UINT_MAX >> 9)?

Aside from that, I'm in favor of seeing this late bio splitting patchset
finally land upstream (hopefully in time for the 4.3 merge, Jens?):

Acked-by: Mike Snitzer <snitzer@redhat.com>

p.s. I'll be working with Joe Thornber on optimizing DM (particularly
dm-thinp and dm-cache) once this patchset is included upstream.  You'll
see I've already added a couple WIP dm-thinp patches ontop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-08 18:30 +0200
  Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 08:10 +0200
    Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 08:50 +0200
      Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:00 +0200
        Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 09:10 +0200
          Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:20 +0200
            Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 17:10 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 00:40 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 04:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 04:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Kent Overstreet <kent.overstreet@gmail.com> - 2015-08-11 05:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 16:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 23:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-12 02:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-12 06:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 19:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 19:50 +0200
                Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200

csiph-web