Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1203583

Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date 2015-08-09 08:50 +0200
Message-ID <pVsAF-6A9-3@gated-at.bofh.it> (permalink)
References (3 earlier) <pSqc4-1ju-53@gated-at.bofh.it> <pSyVY-5uK-15@gated-at.bofh.it> <pSHZh-1KK-7@gated-at.bofh.it> <pVfap-427-1@gated-at.bofh.it> <pVrXX-5Ro-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 08, 2015 at 10:59:50PM -0700, Ming Lin wrote:
> +/*
> + * Ensure that max discard sectors doesn't overflow bi_size and hopefully
> + * it is of the proper granularity as long as the granularity is a power
> + * of two.
> + */
> +#define MAX_DISCARD_SECTORS ((1U << 31) >> 9)

Thisn't isn't MAX_DISCARD_SECTORS, it's MAX_BIO_SECTORS.  If we ever
to something like Kent's multipage biovecs we'll actually need it for
regular read/write bios in addition to discard and write same.

Except for that the patch looks reasonable to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-08 18:30 +0200
  Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 08:10 +0200
    Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 08:50 +0200
      Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:00 +0200
        Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 09:10 +0200
          Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:20 +0200
            Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 17:10 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 00:40 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 04:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 04:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Kent Overstreet <kent.overstreet@gmail.com> - 2015-08-11 05:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 16:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 23:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-12 02:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-12 06:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 19:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 19:50 +0200
                Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200

csiph-web