Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204466

Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios

From Ming Lin <mlin@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date 2015-08-10 20:20 +0200
Message-ID <pVZPY-5HD-25@gated-at.bofh.it> (permalink)
References (7 earlier) <pVsKm-6Lu-3@gated-at.bofh.it> <pVsU2-7cA-7@gated-at.bofh.it> <pVt3I-7nX-1@gated-at.bofh.it> <pVWS5-1tl-9@gated-at.bofh.it> <pVY7w-3bG-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-08-10 at 12:22 -0400, Martin K. Petersen wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
> 
> Mike> Shouldn't we also be using MAX_BIO_SECTORS in
> Mike> blkdev_issue_write_same (instead of UINT_MAX >> 9)?
> 
> The granularity of WRITE SAME is always 1 logical block and there is no
> reason to round it down to the next power of two.
> 
> +/*
> + * Ensure that max discard sectors doesn't overflow bi_size and hopefully
> + * it is of the proper granularity as long as the granularity is a power
> + * of two.
> + */
> +#define MAX_DISCARD_SECTORS ((1U << 31) >> 9)
> +
> 
> That's fine for SATA since we're already capping at 2TB minus change.
> But it means we'll be capping unnecessarily on SCSI. And larger range
> counts are impending in SATA as well.
> 
> So this goes back to my original comment: The only place there can be a
> discard granularity is for SCSI UNMAP. And consequently, we should only
> enforce alignment and granularity when that code path is taken in sd.c.
> 
> I'm OK with Ming's patch series in general. Let's leave the discard cap
> at UINT_MAX and I'll twiddle the rest in SCSI.

Just to make sure I didn't misunderstand it.

Did you mean still use (UINT_MAX >> 9) in blkdev_issue_discard()?

	req_sects = min_t(sector_t, nr_sects, UINT_MAX >> 9);
instead of:
	req_sects = min_t(sector_t, nr_sects, MAX_DISCARD_SECTORS);

But that doesn't work for dm-thinp. See Kent's suggestion to use 1<<31.
https://www.redhat.com/archives/dm-devel/2015-August/msg00053.html

> 
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> 

Thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-08 18:30 +0200
  Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 08:10 +0200
    Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 08:50 +0200
      Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:00 +0200
        Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Christoph Hellwig <hch@infradead.org> - 2015-08-09 09:10 +0200
          Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request  handle arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-09 09:20 +0200
            Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 17:10 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 18:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 00:40 +0200
              Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-10 18:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-10 20:20 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 04:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 04:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Kent Overstreet <kent.overstreet@gmail.com> - 2015-08-11 05:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 16:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-11 23:00 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-12 02:30 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Ming Lin <mlin@kernel.org> - 2015-08-12 06:50 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 19:40 +0200
                Re: [PATCH v5 01/11] block: make generic_make_request handle  arbitrarily sized bios Mike Snitzer <snitzer@redhat.com> - 2015-08-11 19:50 +0200
                Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-08-11 20:10 +0200

csiph-web