Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14156

Re: a review of your bumblebee-status package

Show key headers only | View raw

On Tue, Jun 07, 2022 at 09:47:14AM -0400, Antoine Beaupré wrote:
> >>> _version.py is not a copy of versioneer, it's *generated* by versioneer.
> >>> However, there is versioneer.py in the root directory, which is. I'll
> >>> exclude that from the source and repack.
> >> 
> >> hmm... how about that generated file though? shouldn't it be ... well,
> >> generated at build time instead? :)
> >
> > As far as I understand it, this file is used by the author of the 
> > program, not end users. I don't understand it well, though, because I 
> > haven't put much time into researching what versioneer even does.
> > If my hunch is correct, I may be able to just remove the file from the 
> > source altogether, but I haven't tried that yet.
> 
> Well, it's used by the program to show the version info, so it's
> *eventually* used by users for sure.
> 
> I think just removing the file is a good first guess.

Removing the file is a bad idea!  Replacing it with the PyPI version
(through debian/patches) is a much better approach.  (And possibly
excluding the file in debian/copyright as well.)

   Julian

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: a review of your bumblebee-status package Ben Westover <kwestover.kw@gmail.com> - 2022-06-07 02:10 +0200
  Re: a review of your bumblebee-status package Ben Westover <kwestover.kw@gmail.com> - 2022-06-07 03:20 +0200
    Re: a review of your bumblebee-status package Antoine Beaupré <anarcat@debian.org> - 2022-06-07 04:30 +0200
      Re: a review of your bumblebee-status package Ben Westover <kwestover.kw@gmail.com> - 2022-06-07 04:50 +0200
        Re: a review of your bumblebee-status package Andrey Rahmatullin <wrar@debian.org> - 2022-06-07 08:20 +0200
        Re: a review of your bumblebee-status package Julian Gilbey <julian@d-and-j.net> - 2022-06-07 08:20 +0200
          Re: a review of your bumblebee-status package Antoine Beaupré <anarcat@debian.org> - 2022-06-07 15:50 +0200
            Re: a review of your bumblebee-status package Julian Gilbey <julian@d-and-j.net> - 2022-06-07 16:50 +0200
              Re: a review of your bumblebee-status package Julian Gilbey <julian@d-and-j.net> - 2022-06-07 17:00 +0200
                Re: a review of your bumblebee-status package Ben Westover <kwestover.kw@gmail.com> - 2022-06-08 00:50 +0200
                Re: a review of your bumblebee-status package Antoine Beaupré <anarcat@debian.org> - 2022-06-08 15:30 +0200
              Re: a review of your bumblebee-status package Antoine Beaupré <anarcat@debian.org> - 2022-06-07 17:00 +0200
        Re: a review of your bumblebee-status package Antoine Beaupré <anarcat@debian.org> - 2022-06-07 15:50 +0200
          Re: a review of your bumblebee-status package Julian Gilbey <julian@d-and-j.net> - 2022-06-07 17:00 +0200
            Re: a review of your bumblebee-status package Julian Gilbey <julian@d-and-j.net> - 2022-06-07 17:10 +0200
        Versioneer [was Re: a review of your bumblebee-status package] Timo Röhling <roehling@debian.org> - 2022-06-07 16:30 +0200
          Re: Versioneer [was Re: a review of your bumblebee-status package] Paul Wise <pabs@debian.org> - 2022-06-08 03:30 +0200

csiph-web