Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Julian Gilbey Newsgroups: linux.debian.maint.python Subject: Re: a review of your bumblebee-status package Date: Tue, 07 Jun 2022 17:00:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jun 7 14:59:38 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.19 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -4.6 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailing-List: archive/latest/19984 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/Yp9nylOxkzbkdGJL@d-and-j.net Approved: robomod@news.nic.it Lines: 24 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Ben Westover , debian-python@lists.debian.org X-Original-Date: Tue, 7 Jun 2022 15:59:22 +0100 X-Original-Message-ID: X-Original-References: <87sfohoni3.fsf@curie.anarc.at> <0f84e96b-c0eb-2d0e-fc7e-a8b272549aea@gmail.com> <87fskhb44h.fsf@angela.anarc.at> <367c1fcc-e57e-bde4-61eb-787042586a60@gmail.com> <87sfogziu5.fsf@curie.anarc.at> Xref: csiph.com linux.debian.maint.python:14156 On Tue, Jun 07, 2022 at 09:47:14AM -0400, Antoine Beaupré wrote: > >>> _version.py is not a copy of versioneer, it's *generated* by versioneer. > >>> However, there is versioneer.py in the root directory, which is. I'll > >>> exclude that from the source and repack. > >> > >> hmm... how about that generated file though? shouldn't it be ... well, > >> generated at build time instead? :) > > > > As far as I understand it, this file is used by the author of the > > program, not end users. I don't understand it well, though, because I > > haven't put much time into researching what versioneer even does. > > If my hunch is correct, I may be able to just remove the file from the > > source altogether, but I haven't tried that yet. > > Well, it's used by the program to show the version info, so it's > *eventually* used by users for sure. > > I think just removing the file is a good first guess. Removing the file is a bad idea! Replacing it with the PyPI version (through debian/patches) is a much better approach. (And possibly excluding the file in debian/copyright as well.) Julian