Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #72467

Bug#990279: Also affects stable...

From Timothy Pearson <tpearson@raptorengineering.com>
Newsgroups linux.debian.bugs.dist, linux.debian.kernel
Subject Bug#990279: Also affects stable...
Date 2021-07-25 23:20 +0200
Message-ID <CETHr-6xS-5@gated-at.bofh.it> (permalink)
References <CEEp3-5Fa-1@gated-at.bofh.it> <Ctxhf-3p8-1@gated-at.bofh.it> <CEEp3-5Fa-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw


Reverting this patch restores the GPU to functionality:

drm/amdgpu: check alignment on CPU page for bo map

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index dc4d6ae71476..a01c158bc29f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2198,8 +2198,8 @@ int amdgpu_vm_bo_map(struct amdgpu_device *adev,
        uint64_t eaddr;

        /* validate the parameters */
-       if (saddr & AMDGPU_GPU_PAGE_MASK || offset & AMDGPU_GPU_PAGE_MASK ||
-           size == 0 || size & AMDGPU_GPU_PAGE_MASK)
+       if (saddr & ~PAGE_MASK || offset & ~PAGE_MASK ||
+           size == 0 || size & ~PAGE_MASK)
                return -EINVAL;

        /* make sure object fit at this offset */
@@ -2264,8 +2264,8 @@ int amdgpu_vm_bo_replace_map(struct amdgpu_device *adev,
        int r;

        /* validate the parameters */
-       if (saddr & AMDGPU_GPU_PAGE_MASK || offset & AMDGPU_GPU_PAGE_MASK ||
-           size == 0 || size & AMDGPU_GPU_PAGE_MASK)
+       if (saddr & ~PAGE_MASK || offset & ~PAGE_MASK ||
+           size == 0 || size & ~PAGE_MASK)
                return -EINVAL;

        /* make sure object fit at this offset */

As nearly all POWER distros ship a 64k page kernel, the switch from AMDGPU_GPU_PAGE_MASK to PAGE_MASK may be at fault.

As an aside, it seems there is little to no QA for POWER desktop systems from the Debian developers.  If this is due to lack of hardware access, we may be able to assist.

----- Original Message -----
> From: "Timothy Pearson" <tpearson@raptorengineering.com>
> To: "990279" <990279@bugs.debian.org>
> Sent: Saturday, July 24, 2021 11:42:02 PM
> Subject: Also affects stable...

> Just hit this upgrading a stable box from 4.19.0-6-powerpc64le to
> 4.19.0-17-powerpc64le.  AMD RX480, works perfectly again after downgrading to
> the older kernel.

Back to linux.debian.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Bug#990279: linux-image-5.10.0-7-powerpc64le: Upgrade to 5.10.0-7-powerpc64le from 5.10.0-0.bpo.5-powerpc64le breaks amdgpu Nathaniel Wesley Filardo <nwfilardo@gmail.com> - 2021-06-24 15:20 +0200
  Bug#990279: Also affects stable... Timothy Pearson <tpearson@raptorengineering.com> - 2021-07-25 07:00 +0200
    Bug#990279: Also affects stable... Timothy Pearson <tpearson@raptorengineering.com> - 2021-07-25 23:20 +0200
  Bug#990279: linux-image-5.10.0-7-powerpc64le: Upgrade to 5.10.0-7-powerpc64le from 5.10.0-0.bpo.5-powerpc64le breaks amdgpu Nathaniel Filardo <nwfilardo@gmail.com> - 2021-08-10 03:30 +0200
  Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Nathaniel Filardo <nwfilardo@gmail.com> - 2021-10-10 16:00 +0200
    Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Xi Ruoyao <xry111@mengyan1223.wang> - 2021-10-10 16:30 +0200
  Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Salvatore Bonaccorso <carnil@debian.org> - 2021-10-13 22:20 +0200
    Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Salvatore Bonaccorso <carnil@debian.org> - 2021-10-30 16:40 +0200
  Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Nathaniel Filardo <nwfilardo@gmail.com> - 2022-01-28 00:10 +0100
  Bug#990279: 9a89a721b41b (" drm/amdgpu: check alignment on CPU page for bo map") breaks amdgpu on ppc64 machines? Andrew <akaminski@mailfence.com> - 2022-01-29 00:20 +0100
  Bug#990279: Status? Timothy Pearson <tpearson@raptorengineering.com> - 2022-02-08 20:40 +0100
    Bug#990279: Status? Salvatore Bonaccorso <carnil@debian.org> - 2022-02-08 22:30 +0100
  Bug#990279: Status? Timothy Pearson <tpearson@raptorengineering.com> - 2022-02-08 22:30 +0100
  Bug#990279: Status? Timothy Pearson <tpearson@raptorengineering.com> - 2022-02-09 20:30 +0100
    Bug#990279: Status? Salvatore Bonaccorso <carnil@debian.org> - 2022-02-09 21:30 +0100
      Bug#990279: Status? Timothy Pearson <tpearson@raptorengineering.com> - 2022-02-09 21:30 +0100
  Bug#990279: Status? Andrew <akaminski@mailfence.com> - 2022-03-09 21:10 +0100

csiph-web