Groups > comp.lang.java.programmer > #22974

Re: Final Fantasy 2 based game source code

From	"Qu0ll" <Qu0llSixFour@gmail.com>
Newsgroups	comp.lang.java.programmer
References	<m0r4jbcc96.fsf@gmail.com> <171686ae-5239-4502-9ef3-65a68e8a1a1d@googlegroups.com> <slrnkkiom1.nnr.fredrik@biggles.jonson.org>
Subject	Re: Final Fantasy 2 based game source code
Date	2013-03-20 20:28 +1100
Message-ID	<X8GdnecbBs7bHNTMnZ2dnUVZ_uKdnZ2d@westnet.com.au> (permalink)

Show all headers | View raw

"Fredrik Jonson"  wrote in message 
news:slrnkkiom1.nnr.fredrik@biggles.jonson.org...

[Apologies for the lack of indentation, reply at end of post]

Lew wrote:

>  Turtle Wizard wrote:
> > Final Fantasy 2 based game written in Java : source code GPLv2 :
> > http://code.google.com/p/angels-destiny-rpg/
>
> [Snip Lew's code review]

Lew, I want to start with a thank you for conducting a code review on
Turtle's project. Technically it is mostly resonable advice.

The problem is - and I'm not sure you are aware - the tone in your review
could be perceived as rather hostile, you even shout at one place.  Do you
think people are more prone to listen to your advice when you shout? Also
you needlessly use negative adjectives, like "clumsy" and "strange", where
it would suffice to describe the technical problem with the code.

Could it be possible that people would be more inclined to take your advice
to heart if you took another approach?

This is usenet, and obviously you are free to post in whatever tone you
like. However, there is something to be said for being kind to others,
especially newbies and people you do not know.

-----------------------------------

Let me offer you some advice Fredrik.

I have observed Lew's comments and behaviour in this group for several 
years.  While he may come across as "hostile" or "rude" on first impression, 
I believe he is not trying to be either of those things.  There is no doubt 
that Lew has excellent skills and knowledge in Java and you can do far worse 
than to follow his advice or learn from him.  He reviewed your code and 
provided some feedback because he wanted to help you, not to get his jollies 
belittling you or showing how clever he is.  He didn't have to do that (it 
takes time and effort) and he gains nothing from it other than the 
satisfaction of helping people.

The other thing to remember is that the world is a tough place and to 
succeed as a developer you need to be able to compete on the world stage and 
amongst talented peers.  Had Lew delivered a "softer" response you may have 
been less likely to react in a positive, motivated way.  Prospective 
employers would most likely be much harder on you than Lew has been. 
Programmers competing with you for a position or trying to get ahead of you 
in the workplace will also not be so generous and are unlikely to be as 
courteous.

I strongly suggest you accept the (constructive) criticism and strive to be 
a better developer.

I also wanted to add something along the lines of "If you can't stand the 
heat then get out of the kitchen" but I struggled to frame that analogy in 
the terms of software development.

--
And loving it,

-Qu0ll (Rare, not extinct)
_________________________________________________
Qu0llSixFour@gmail.com
[Replace the "SixFour" with numbers to email me]

Thread

Final Fantasy 2 based game source code Turtle Wizard <elvishNOSPAM.healer@gmail.com> - 2013-03-19 22:26 +0100
  Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-19 18:49 -0700
    Re: Final Fantasy 2 based game source code Fredrik Jonson <fredrik@jonson.org> - 2013-03-20 07:18 +0000
      Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-20 20:28 +1100
        Re: Final Fantasy 2 based game source code Fredrik Jonson <fredrik@jonson.org> - 2013-03-20 13:34 +0000
          Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-20 12:07 -0700
            Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:26 -0400
              Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-21 08:11 +0000
                Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 20:58 +1100
              Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-21 12:29 -0700
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 20:34 +0000
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:56 -0400
                Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-21 15:24 -0700
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 09:18 +0000
                Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-22 07:15 -0300
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 13:54 +0000
                Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 10:25 -0700
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 18:14 +0000
                Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 13:22 -0700
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 20:26 +0000
                Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 13:32 -0700
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 21:39 +0000
                Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 08:50 +1100
                Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-22 23:26 +0100
                Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 09:39 +1100
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:15 -0400
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:12 -0400
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:08 -0400
                Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-23 10:59 +0000
                Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 15:33 +0000
                Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-22 10:19 -0500
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 16:57 +0000
                Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-22 14:07 -0500
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 20:09 +0000
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:31 -0400
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 08:54 +0000
                Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-23 23:01 -0500
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-24 10:04 +0000
                Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-24 17:07 -0300
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-25 09:19 +0000
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-25 09:26 +0000
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:49 -0400
                Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-23 11:12 +0000
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 15:24 +0000
                Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 16:21 +0000
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 17:10 +0000
                Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 18:27 +0000
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 18:51 +0000
                Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-23 22:00 -0300
                Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:19 -0400
          Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 14:12 +1100
            Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 09:06 +0000
              Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 20:57 +1100
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 10:42 +0000
                Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 22:11 +1100
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 11:53 +0000
            Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:58 -0400
        Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 13:51 +0000
          Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-20 09:28 -0500
            Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 15:03 +0000
            Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:32 -0400
          Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 17:52 +0100
            Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 17:43 +0000
              Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 10:01 +1100
                Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 08:35 +0000
              Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:35 -0400
        Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:18 -0400
        Re: Final Fantasy 2 based game source code Jim Janney <jjanney@shell.xmission.com> - 2013-03-22 18:00 -0600
          Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 11:08 +1100
            Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:26 -0400
      Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 12:41 +0100
        Re: Final Fantasy 2 based game source code paul.cager@gmail.com - 2013-03-20 05:59 -0700
          Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 17:49 +0100
            Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-20 20:33 +0100
              Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 23:15 +0100
                Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-21 00:11 +0100
                Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-21 00:27 +0100
        Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:39 -0400
          Re: Final Fantasy 2 based game source code Gene Wirchenko <genew@telus.net> - 2013-03-21 10:01 -0700
            Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:39 -0400
            Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-22 01:21 +0100
    Re: Final Fantasy 2 based game source code bubble <bubble@soft29.vub.ac.be> - 2013-03-24 14:16 +0000

csiph-web