Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > comp.lang.java.programmer > #22972
| Newsgroups | comp.lang.java.programmer |
|---|---|
| Date | 2013-03-19 18:49 -0700 |
| References | <m0r4jbcc96.fsf@gmail.com> |
| Message-ID | <171686ae-5239-4502-9ef3-65a68e8a1a1d@googlegroups.com> (permalink) |
| Subject | Re: Final Fantasy 2 based game source code |
| From | Lew <lewbloch@gmail.com> |
Turtle Wizard wrote:
> Final Fantasy 2 based game written in Java : source code GPLv2 :
> http://code.google.com/p/angels-destiny-rpg/
- You should follow the Java Coding Conventions, at least as far as indentation and
naming are concerned.
- Consider encapsulating the long initialization sequences in methods of the class
being initialized.
- Sequences like
public Image getFirstCharacterLeftImage(int idx)
{
return firstplayercharacter.getLeftImage(idx);
}
public Image getSecondCharacterLeftImage(int idx)
{
return secondplayercharacter.getLeftImage(idx);
}
public Image getThirdCharacterLeftImage(int idx)
{
return thirdplayercharacter.getLeftImage(idx);
}
...
are clumsy programming. Those should be calls the the same method,
e.g., 'getLeftImage()', from each of the first, second, third, ... instances of
some sort of 'GameCharacter' type.
What you've done is the antithesis of object oriented.
- Eschew import-on-demand for single-type imports.
- Your hierarchies are strange, for example 'CityNameDatabaseBase'. Why is that split
into two types?
- Speaking of 'CityNameDatabaseBase',
protected LinkedList words = new LinkedList();
DO NOT USE RAW TYPES! YECCCH!
Declare the variable as a 'List<Something>', or 'Set<Something>', or 'Collection<Something>'.
And why did you select 'LinkedList' for the implementation? Didn't 'ArrayList' suffice?
And really, shouldn't it be a 'Set' (to avoid duplicates) rather than a 'List'?
- Object o = words.get(index);
String s = (String)o;
This is why you don't use raw types. And 'o' and 's' are nasty variable names.
- "Copyright (C) <year> <name of author>"
Really?
- This is not how to do i18n:
if (language == "Dutch" || language == "dutch") {
textlib.addText("Er is onrust in het Oosten..");
textlib.addText("een oud kwaad is aan het herrijzen..");
//set to "-1" for not popping up the learn widget
learnvarlib.addText("-1");
learnvarlib.addText("-1");
asktextlib.addText("Aangenaam.");
itemtextlib.addText("Hopelijk heb je het niet nodig.");
learntextlib.addText("Dulandar is dit elfen dorpje.");
learnedanotherwordtextlib.addText("Elfen dansen en zingen graag.");
Use resource bundles. That's what they're for.
And so on and so on.
I don't know how to evaluate beginner projects, but you have a ways to go.
You need to learn object-oriented programming, and Java.
--
Lew
Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Final Fantasy 2 based game source code Turtle Wizard <elvishNOSPAM.healer@gmail.com> - 2013-03-19 22:26 +0100
Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-19 18:49 -0700
Re: Final Fantasy 2 based game source code Fredrik Jonson <fredrik@jonson.org> - 2013-03-20 07:18 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-20 20:28 +1100
Re: Final Fantasy 2 based game source code Fredrik Jonson <fredrik@jonson.org> - 2013-03-20 13:34 +0000
Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-20 12:07 -0700
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:26 -0400
Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-21 08:11 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 20:58 +1100
Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-21 12:29 -0700
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 20:34 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:56 -0400
Re: Final Fantasy 2 based game source code Lew <lewbloch@gmail.com> - 2013-03-21 15:24 -0700
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 09:18 +0000
Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-22 07:15 -0300
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 13:54 +0000
Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 10:25 -0700
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 18:14 +0000
Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 13:22 -0700
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 20:26 +0000
Re: Final Fantasy 2 based game source code Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2013-03-22 13:32 -0700
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 21:39 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 08:50 +1100
Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-22 23:26 +0100
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 09:39 +1100
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:15 -0400
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:12 -0400
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:08 -0400
Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-23 10:59 +0000
Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 15:33 +0000
Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-22 10:19 -0500
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 16:57 +0000
Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-22 14:07 -0500
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-22 20:09 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:31 -0400
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 08:54 +0000
Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-23 23:01 -0500
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-24 10:04 +0000
Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-24 17:07 -0300
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-25 09:19 +0000
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-25 09:26 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:49 -0400
Re: Final Fantasy 2 based game source code "Chris Uppal" <chris.uppal@metagnostic.REMOVE-THIS.org> - 2013-03-23 11:12 +0000
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 15:24 +0000
Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 16:21 +0000
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 17:10 +0000
Re: Final Fantasy 2 based game source code Martin Gregorie <martin@address-in-sig.invalid> - 2013-03-23 18:27 +0000
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-23 18:51 +0000
Re: Final Fantasy 2 based game source code Arved Sandstrom <asandstrom2@eastlink.ca> - 2013-03-23 22:00 -0300
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:19 -0400
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 14:12 +1100
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 09:06 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 20:57 +1100
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 10:42 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 22:11 +1100
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 11:53 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:58 -0400
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 13:51 +0000
Re: Final Fantasy 2 based game source code Joshua Cranmer 🐧 <Pidgeot18@verizon.invalid> - 2013-03-20 09:28 -0500
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 15:03 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:32 -0400
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 17:52 +0100
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-20 17:43 +0000
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-21 10:01 +1100
Re: Final Fantasy 2 based game source code lipska the kat <"nospam at neversurrender dot co dot uk"> - 2013-03-21 08:35 +0000
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:35 -0400
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:18 -0400
Re: Final Fantasy 2 based game source code Jim Janney <jjanney@shell.xmission.com> - 2013-03-22 18:00 -0600
Re: Final Fantasy 2 based game source code "Qu0ll" <Qu0llSixFour@gmail.com> - 2013-03-23 11:08 +1100
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-22 20:26 -0400
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 12:41 +0100
Re: Final Fantasy 2 based game source code paul.cager@gmail.com - 2013-03-20 05:59 -0700
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 17:49 +0100
Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-20 20:33 +0100
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-20 23:15 +0100
Re: Final Fantasy 2 based game source code Lars Enderin <lars.enderin@telia.com> - 2013-03-21 00:11 +0100
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-21 00:27 +0100
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-20 20:39 -0400
Re: Final Fantasy 2 based game source code Gene Wirchenko <genew@telus.net> - 2013-03-21 10:01 -0700
Re: Final Fantasy 2 based game source code Arne Vajhøj <arne@vajhoej.dk> - 2013-03-21 17:39 -0400
Re: Final Fantasy 2 based game source code Joerg Meier <joergmmeier@arcor.de> - 2013-03-22 01:21 +0100
Re: Final Fantasy 2 based game source code bubble <bubble@soft29.vub.ac.be> - 2013-03-24 14:16 +0000
csiph-web