Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index
Date	2017-09-22 12:20 +0200
Message-ID	<ustdT-4TO-1@gated-at.bofh.it> (permalink)
References	<urMVk-3rX-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 20, 2017 at 02:01:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
> wrong order, they need to be in pin_index, dir order to match the function
> slk_tplg_fill_res_tkn  correctly.
> 
> Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")

thanks for this.


Acked-By: Vinod Koul <vinod.koul@intel.com>
Tested-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Colin King <colin.king@canonical.com> - 2017-09-20 15:10 +0200
  Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function  arguments dir and pin_index Vinod Koul <vinod.koul@intel.com> - 2017-09-22 12:20 +0200

csiph-web