Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735759 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-20 15:10 +0200 |
| Last post | 2017-09-22 12:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Colin King <colin.king@canonical.com> - 2017-09-20 15:10 +0200
Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Vinod Koul <vinod.koul@intel.com> - 2017-09-22 12:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-20 15:10 +0200 |
| Subject | [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index |
| Message-ID | <urMVk-3rX-11@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
wrong order, they need to be in pin_index, dir order to match the function
slk_tplg_fill_res_tkn correctly.
Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")
Fixes: f6fa56e22559 ("ASoC: Intel: Skylake: Parse and update module config structure")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..27bcb62568fb 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -2382,7 +2382,7 @@ static int skl_tplg_get_token(struct device *dev,
case SKL_TKN_U32_MAX_MCPS:
case SKL_TKN_U32_OBS:
case SKL_TKN_U32_IBS:
- ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, dir, pin_index);
+ ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, pin_index, dir);
if (ret < 0)
return ret;
--
2.14.1
[toc] | [next] | [standalone]
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2017-09-22 12:20 +0200 |
| Subject | Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index |
| Message-ID | <ustdT-4TO-1@gated-at.bofh.it> |
| In reply to | #1735759 |
On Wed, Sep 20, 2017 at 02:01:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
> wrong order, they need to be in pin_index, dir order to match the function
> slk_tplg_fill_res_tkn correctly.
>
> Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")
thanks for this.
Acked-By: Vinod Koul <vinod.koul@intel.com>
Tested-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
--
~Vinod
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web