Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730151

Re: [PATCH] sysrq : fix Show Regs call trace on ARM

From Jiri Slaby <jslaby@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] sysrq : fix Show Regs call trace on ARM
Date 2017-09-11 07:30 +0200
Message-ID <uopsd-6Pm-3@gated-at.bofh.it> (permalink)
References <uonqp-5jQ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 09/11/2017, 05:11 AM, Jibin Xu wrote:
...
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
>  	 * architecture has no support for it:
>  	 */
>  	if (!trigger_all_cpu_backtrace()) {
> -		struct pt_regs *regs = get_irq_regs();
> +		struct pt_regs *regs = NULL;
>  
> +		if (in_irq())
> +			regs = get_irq_regs();

Maybe a stupid question: how does get_irq_regs() behave in the softirq
context? I.e. what about s/in_irq/in_interrupt/?

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 05:20 +0200
  Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-11 07:30 +0200
    Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 12:00 +0200
      Re: Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:10 +0200
        Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:20 +0200

csiph-web