Re: [PATCH] sysrq : fix Show Regs call trace on ARM

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sysrq : fix Show Regs call trace on ARM
Date	2017-09-13 08:20 +0200
Message-ID	<up9bH-3Gc-3@gated-at.bofh.it> (permalink)
References	<uonqp-5jQ-1@gated-at.bofh.it> <uopsd-6Pm-3@gated-at.bofh.it> <uotFv-1dY-9@gated-at.bofh.it> <up922-3D3-7@gated-at.bofh.it> <up922-3D3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/13/2017, 08:04 AM, Jiri Slaby wrote:
> On 09/11/2017, 01:22 PM, Jibin Xu wrote:
>> Hi,Jiri: 
>>
>> I tested get_irq_regs() behave in the softirq context,
>> I called get_irq_regs() by a tasklet, It returns NULL.My understanding is get_irq_regs() can return the right result
>> only in hardware IRQ,otherwise it returns ï¼®ï¼µï¼¬L.
>> So I think in_irq() would be better.
> 
> Hi,
> 
> tasklets are run in the process context (in a kthread). But what about
> timers? HARDIRQ is decremented, SOFTIRQ remains set and sysrq handlers
> are called in such conditions (in_interrupt() is true, in_irq() is
> false). At that moment, irq_regs are still set and valid IMO.
> 
> But I would believe for now that sysrq handlers are not invoked from
> softirq context. AFAIK they are called only from hardirq (serial port or
> keyboard IRQ handler) or process context (write to /proc/sysrq-trigger).
> So this change *should* be safe unless someone else objects there are
> some kgdb special cases or something.

Oops, serial8250_timeout actually can do so. So yes, sysrq handlers can
be invoked from softirq (timer) context and they still should print the
registers at best.

I have to leave now, will look into it later if someone (you :)) doesn't
beat me to it.

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 05:20 +0200
  Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-11 07:30 +0200
    Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 12:00 +0200
      Re: Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:10 +0200
        Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:20 +0200

csiph-web