Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731389

Re: Re: [PATCH] sysrq : fix Show Regs call trace on ARM

Show all headers | View raw

On 09/11/2017, 01:22 PM, Jibin Xu wrote:
> Hi,Jiri: 
> 
> I tested get_irq_regs() behave in the softirq context,
> I called get_irq_regs() by a tasklet, It returns NULL.My understanding is get_irq_regs() can return the right result
> only in hardware IRQ,otherwise it returns ＮＵＬL.
> So I think in_irq() would be better.

Hi,

tasklets are run in the process context (in a kthread). But what about
timers? HARDIRQ is decremented, SOFTIRQ remains set and sysrq handlers
are called in such conditions (in_interrupt() is true, in_irq() is
false). At that moment, irq_regs are still set and valid IMO.

But I would believe for now that sysrq handlers are not invoked from
softirq context. AFAIK they are called only from hardirq (serial port or
keyboard IRQ handler) or process context (write to /proc/sysrq-trigger).
So this change *should* be safe unless someone else objects there are
some kgdb special cases or something.

> thanks,
> Jibin Xu
> 
> On 2017年09月11日 17:55, Jibin Xu wrote:
> 
>> Hi,Jiri:
>> get_irq_regs() in the softirq context return NULL.
>> thanks,
>> Jibin Xu
>> On 2017年09月11日 13:24, Jiri Slaby wrote:
>>> On 09/11/2017, 05:11 AM, Jibin Xu wrote:
>>> ...
>>>> --- a/drivers/tty/sysrq.c
>>>> +++ b/drivers/tty/sysrq.c
>>>> @@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
>>>>        * architecture has no support for it:
>>>>        */
>>>>       if (!trigger_all_cpu_backtrace()) {
>>>> -        struct pt_regs *regs = get_irq_regs();
>>>> +        struct pt_regs *regs = NULL;
>>>>   
>>>> +        if (in_irq())
>>>> +            regs = get_irq_regs();
>>> Maybe a stupid question: how does get_irq_regs() behave in the softirq
>>> context? I.e. what about s/in_irq/in_interrupt/?
>>> thanks,
>>
> 


-- 
js
suse labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 05:20 +0200
  Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-11 07:30 +0200
    Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jibin Xu <jibin.xu@windriver.com> - 2017-09-11 12:00 +0200
      Re: Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:10 +0200
        Re: [PATCH] sysrq : fix Show Regs call trace on ARM Jiri Slaby <jslaby@suse.cz> - 2017-09-13 08:20 +0200

csiph-web