Groups > linux.kernel > #1719442

Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width.

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width.
Date	2017-08-24 19:00 +0200
Message-ID	<ui3E6-Db-29@gated-at.bofh.it> (permalink)
References	(3 earlier) <ui2yl-8q8-5@gated-at.bofh.it> <ui2I1-8tG-13@gated-at.bofh.it> <ui2RH-kG-1@gated-at.bofh.it> <ui3b4-tc-35@gated-at.bofh.it> <ui3uq-zR-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/08/2017 18:21, Yu Zhang wrote:
> 
> 
> On 8/25/2017 12:27 AM, Paolo Bonzini wrote:
>> On 24/08/2017 17:38, Yu Zhang wrote:
>>>>
>>>> In practice, MAXPHYADDR will never be 59 even because the PKRU bits are
>>>> at bits 59..62.
>>> Thanks, Paolo.
>>> I see. I had made an assumption that MAXPHYADDR shall not exceed the
>>> physical one,
>>> which is 52 I believe. But I'm not sure there's any place to check this.
>>> Maybe we should make sure the vcpu->arch.maxphyaddr will not be greater
>>> than the value of the host?
>> That's a separate change anyway.  In any case, since currently the
>> MAXPHYADDR is not validated, your change to rsvd_bits makes sense.
> 
> Thanks, Paolo.
> As to this patch series, any change I need do?

No, it's fine.

> BTW,  I have written a patch for kvm-unit-test access test, but the test
> failed.
> Not sure if my patch is erroneous or due to a simulator error. I'll send
> out the
> test patch after it works.:-)

Try to send it.  I can also test it with QEMU TCG.

Paolo

Thread

[PATCH v3 0/5] KVM: MMU: 5 level EPT/shadow support Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 15:00 +0200
  [PATCH v3 4/5] KVM: MMU: Add 5 level EPT & Shadow page table support. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 15:00 +0200
    Re: [PATCH v3 4/5] KVM: MMU: Add 5 level EPT & Shadow page table  support. Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 15:50 +0200
  [PATCH v3 1/5] KVM: x86: Add return value to kvm_cpuid(). Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 15:00 +0200
  [PATCH v3 5/5] KVM: MMU: Expose the LA57 feature to VM. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 15:00 +0200
  [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 15:00 +0200
    Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 15:50 +0200
      Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 17:50 +0200
        Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 18:00 +0200
          Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 18:10 +0200
            Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 18:30 +0200
              Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-08-24 18:50 +0200
                Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on  its physical address width. Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 19:00 +0200
  Re: [PATCH v3 0/5] KVM: MMU: 5 level EPT/shadow support Paolo Bonzini <pbonzini@redhat.com> - 2017-08-24 15:50 +0200

csiph-web