Groups > linux.kernel > #1719443

Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning
Date	2017-08-24 19:00 +0200
Message-ID	<ui3E6-Db-27@gated-at.bofh.it> (permalink)
References	<udmel-6sy-7@gated-at.bofh.it> <udmHn-6RA-9@gated-at.bofh.it> <uervk-72Y-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 14, 2017 at 10:36:03AM -0700, Nick Desaulniers wrote:
> Minor nit for the commit message that can get fixed up when being merged:
> 
> On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> 
> > if (x)
> >   return
> > ...
> >
> > rather than:
> >
> > if (!x == 0)
> 
> should remove the `!`, ex:
> 
> if (x == 0)

Amended this here, and applied. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-14 19:40 +0200
  Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-24 18:30 +0200
  Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses  warning Pablo Neira Ayuso <pablo@netfilter.org> - 2017-08-24 19:00 +0200

csiph-web