Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710909

Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions

Show all headers | View raw

On Mon, Aug 14, 2017 at 12:14:32PM +0100, Catalin Marinas wrote:
> On Mon, Aug 14, 2017 at 11:35:02AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Mon, 14 Aug 2017 10:50:22 +0200
> > 
> > Omit an extra message for a memory allocation failure in these functions.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  mm/kmemleak.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> > index 7780cd83a495..c6c798d90b2e 100644
> > --- a/mm/kmemleak.c
> > +++ b/mm/kmemleak.c
> > @@ -555,7 +555,6 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
> >  
> >  	object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
> >  	if (!object) {
> > -		pr_warn("Cannot allocate a kmemleak_object structure\n");
> >  		kmemleak_disable();
> 
> I don't really get what this patch is trying to achieve. Given that
> kmemleak will be disabled after this, I'd rather know why it happened.

kmem_cache_alloc() will generate a stack trace and a bunch of more
useful information if it fails.  The allocation isn't likely to fail,
but if it does you will know.  The extra message is just wasting RAM.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] kmemleak: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 11:40 +0200
  [PATCH 1/2] kmemleak: Delete an error message for a failed memory  allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 11:40 +0200
    Re: [PATCH 1/2] kmemleak: Delete an error message for a failed  memory allocation in two functions Catalin Marinas <catalin.marinas@arm.com> - 2017-08-14 13:20 +0200
      Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory  allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 13:50 +0200
      Re: [PATCH 1/2] kmemleak: Delete an error message for a failed  memory allocation in two functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-14 15:10 +0200
        Re: [PATCH 1/2] kmemleak: Delete an error message for a failed  memory allocation in two functions Catalin Marinas <catalin.marinas@arm.com> - 2017-08-14 16:40 +0200
          Re: [PATCH 1/2] kmemleak: Delete an error message for a failed  memory allocation in two functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-14 16:50 +0200

csiph-web