Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710870
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions |
| Date | 2017-08-14 13:50 +0200 |
| Message-ID | <uem2C-3DE-29@gated-at.bofh.it> (permalink) |
| References | <uek0N-2qo-23@gated-at.bofh.it> <uek0O-2qo-39@gated-at.bofh.it> <uelzA-3tE-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +++ b/mm/kmemleak.c
>> @@ -555,7 +555,6 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
>>
>> object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
>> if (!object) {
>> - pr_warn("Cannot allocate a kmemleak_object structure\n");
>> kmemleak_disable();
>
> I don't really get what this patch is trying to achieve.
I suggest to reduce the code size a bit.
> Given that kmemleak will be disabled after this,
I have got difficulties to interpret this information.
> I'd rather know why it happened.
Do you find the default allocation failure report sufficient?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] kmemleak: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 11:40 +0200
[PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 11:40 +0200
Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions Catalin Marinas <catalin.marinas@arm.com> - 2017-08-14 13:20 +0200
Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-14 13:50 +0200
Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-14 15:10 +0200
Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions Catalin Marinas <catalin.marinas@arm.com> - 2017-08-14 16:40 +0200
Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-14 16:50 +0200
csiph-web