Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703732
| From | Dave Airlie <airlied@linux.ie> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/10] agp: uninorth: constify pci_device_id. |
| Date | 2017-08-04 09:20 +0200 |
| Message-ID | <uaF3P-3UX-1@gated-at.bofh.it> (permalink) |
| References | <u9HU5-68E-3@gated-at.bofh.it> <u9HU7-68E-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 1 Aug 2017, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
I've merged all the agp ones into drm-next.
Dave.
> ---
> drivers/char/agp/uninorth-agp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> index fdced54..c381c8e 100644
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev)
> agp_put_bridge(bridge);
> }
>
> -static struct pci_device_id agp_uninorth_pci_table[] = {
> +static const struct pci_device_id agp_uninorth_pci_table[] = {
> {
> .class = (PCI_CLASS_BRIDGE_HOST << 8),
> .class_mask = ~0,
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/10] constify char pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
[PATCH 02/10] agp: amd-k7: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
[PATCH 06/10] agp: efficeon: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
[PATCH 01/10] agp: uninorth: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
Re: [PATCH 01/10] agp: uninorth: constify pci_device_id. Dave Airlie <airlied@linux.ie> - 2017-08-04 09:20 +0200
[PATCH 05/10] agp: ati: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
[PATCH 07/10] agp: sis: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
[PATCH 10/10] applicom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
[PATCH 08/10] agp: amd64: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
[PATCH 09/10] agp: nvidia: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
csiph-web