Re: [PATCH 01/10] agp: uninorth: constify pci_device_id.

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Dave Airlie <airlied@linux.ie>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/10] agp: uninorth: constify pci_device_id.
Date	Fri, 04 Aug 2017 09:20:01 +0200
Message-ID	<uaF3P-3UX-1@gated-at.bofh.it> (permalink)
References	<u9HU5-68E-3@gated-at.bofh.it> <u9HU7-68E-33@gated-at.bofh.it>
X-Original-To	Arvind Yadav <arvind.yadav.cs@gmail.com>
X-Greylist	delayed 579 seconds by postgrey-1.27 at vger.kernel.org; Fri, 04 Aug 2017 03:11:29 EDT
X-X-Sender	airlied@skynet.skynet.ie
User-Agent	Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 4 Aug 2017 08:01:46 +0100 (IST)
X-Original-Message-ID	<alpine.DEB.2.00.1708040801300.9612@skynet.skynet.ie>
X-Original-References	<1501603317-22947-1-git-send-email-arvind.yadav.cs@gmail.com> <1501603317-22947-2-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1703732

Show key headers only | View raw

On Tue, 1 Aug 2017, Arvind Yadav wrote:

> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

I've merged all the agp ones into drm-next.

Dave.

> ---
>  drivers/char/agp/uninorth-agp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> index fdced54..c381c8e 100644
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev)
>  	agp_put_bridge(bridge);
>  }
>  
> -static struct pci_device_id agp_uninorth_pci_table[] = {
> +static const struct pci_device_id agp_uninorth_pci_table[] = {
>  	{
>  	.class		= (PCI_CLASS_BRIDGE_HOST << 8),
>  	.class_mask	= ~0,
>

Thread

[PATCH 00/10] constify char pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 02/10] agp: amd-k7: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 06/10] agp: efficeon: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 01/10] agp: uninorth: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
    Re: [PATCH 01/10] agp: uninorth: constify pci_device_id. Dave Airlie <airlied@linux.ie> - 2017-08-04 09:20 +0200
  [PATCH 05/10] agp: ati: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 07/10] agp: sis: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 10/10] applicom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 08/10] agp: amd64: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 09/10] agp: nvidia: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200

csiph-web