Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701193

[PATCH 02/10] agp: amd-k7: constify pci_device_id.

Show all headers | View raw

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/char/agp/amd-k7-agp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
index 5fbd333..b450544 100644
--- a/drivers/char/agp/amd-k7-agp.c
+++ b/drivers/char/agp/amd-k7-agp.c
@@ -21,7 +21,7 @@
 #define AMD_TLBFLUSH	0x0c	/* In mmio region (32-bit register) */
 #define AMD_CACHEENTRY	0x10	/* In mmio region (32-bit register) */
 
-static struct pci_device_id agp_amdk7_pci_table[];
+static const struct pci_device_id agp_amdk7_pci_table[];
 
 struct amd_page_map {
 	unsigned long *real;
@@ -508,7 +508,7 @@ static int agp_amdk7_resume(struct pci_dev *pdev)
 #endif /* CONFIG_PM */
 
 /* must be the same order as name table above */
-static struct pci_device_id agp_amdk7_pci_table[] = {
+static const struct pci_device_id agp_amdk7_pci_table[] = {
 	{
 	.class		= (PCI_CLASS_BRIDGE_HOST << 8),
 	.class_mask	= ~0,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] constify char pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 02/10] agp: amd-k7: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 06/10] agp: efficeon: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 01/10] agp: uninorth: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
    Re: [PATCH 01/10] agp: uninorth: constify pci_device_id. Dave Airlie <airlied@linux.ie> - 2017-08-04 09:20 +0200
  [PATCH 05/10] agp: ati: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:10 +0200
  [PATCH 07/10] agp: sis: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 10/10] applicom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 08/10] agp: amd64: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200
  [PATCH 09/10] agp: nvidia: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 18:30 +0200

csiph-web