Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697013

Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jul 25, 2017 at 05:10:26PM +0200, Sebastian Reichel wrote:
> Motorola CPCAP is a PMIC with audio functionality, that can be
> found on Motorola Droid 4 and probably a few other phones from
> Motorola's Droid series.

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.  Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.

> +&cpcap {
> +	audio-codec {
> +		compatible = "motorola,cpcap-audio-codec";
> +		vdd-supply = <&vaudio>;
> +	};
> +};

I'd expect supplies (especially generically named supplies like this) to
be looked up at the chip level - aside from my general concerns with MFD
subnodes like this in the case of supplies it's especially problematic
as it makes it harder to do the generic chip level hookup in the DT and
it precludes other parts of the chip using the same supply (which seems
especially likely with a generically named supply like this).

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown <broonie@kernel.org> - 2017-07-26 13:50 +0200
      Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 11:10 +0200
  [PATCHv3 5/6] ARM: dts: motorola-cpcap-mapphone: set initial mode for vaudio Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Takashi Iwai <tiwai@suse.de> - 2017-07-25 17:50 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Mark Brown <broonie@kernel.org> - 2017-07-26 13:40 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 12:10 +0200
  [PATCHv3 6/6] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  Re: [PATCHv3 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-27 14:10 +0200

csiph-web