Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697862

Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, Jul 25, 2017 at 05:42:59PM +0200, Takashi Iwai wrote:
> On Tue, 25 Jul 2017 17:10:25 +0200,
> Sebastian Reichel wrote:
> > Some codecs may need to use this from loadable modules. Without
> > this patch compilation for this kind of codec will fail with the
> > following error:
> > 
> > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> > undefined!
> > 
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> 
> If you do export the function, please make its comments prettier, so
> that it appears in kernel documentation properly as an API function.
> 
> Also, in general, we use snd_ prefix for the exported stuff.
> You'd need to rename it accordingly, too.
> 
> Last but not least, this is specific to ASoC, so use "ASoC" prefix to
> the subject line.

After fixing this locally I noticed, that I no longer need to call
soc_dpcm_runtime_update at all and it can remain private. So this
patch will be dropped in v4.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown <broonie@kernel.org> - 2017-07-26 13:50 +0200
      Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 11:10 +0200
  [PATCHv3 5/6] ARM: dts: motorola-cpcap-mapphone: set initial mode for vaudio Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Takashi Iwai <tiwai@suse.de> - 2017-07-25 17:50 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Mark Brown <broonie@kernel.org> - 2017-07-26 13:40 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 12:10 +0200
  [PATCHv3 6/6] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  Re: [PATCHv3 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-27 14:10 +0200

csiph-web