Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695877

Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update

Show all headers | View raw

On Tue, 25 Jul 2017 17:10:25 +0200,
Sebastian Reichel wrote:
> 
> From: Tony Lindgren <tony@atomide.com>
> 
> Some codecs may need to use this from loadable modules. Without
> this patch compilation for this kind of codec will fail with the
> following error:
> 
> ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> undefined!
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

If you do export the function, please make its comments prettier, so
that it appears in kernel documentation properly as an API function.

Also, in general, we use snd_ prefix for the exported stuff.
You'd need to rename it accordingly, too.

Last but not least, this is specific to ASoC, so use "ASoC" prefix to
the subject line.


thanks,

Takashi

> ---
>  sound/soc/soc-pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index dcc5ece08668..4de7d86ea6fb 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -2539,6 +2539,8 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
>  	mutex_unlock(&card->mutex);
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(soc_dpcm_runtime_update);
> +
>  int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute)
>  {
>  	struct snd_soc_dpcm *dpcm;
> -- 
> 2.13.2
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown <broonie@kernel.org> - 2017-07-26 13:50 +0200
      Re: [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 11:10 +0200
  [PATCHv3 5/6] ARM: dts: motorola-cpcap-mapphone: set initial mode for vaudio Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
    Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Takashi Iwai <tiwai@suse.de> - 2017-07-25 17:50 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Mark Brown <broonie@kernel.org> - 2017-07-26 13:40 +0200
      Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 12:10 +0200
  [PATCHv3 6/6] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-25 17:20 +0200
  Re: [PATCHv3 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-27 14:10 +0200

csiph-web