Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629970

[PATCH 3/7] HID: sensor-hub: Adjust two checks for null pointers in sensor_hub_probe()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 24 Apr 2017 20:00:06 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/hid/hid-sensor-hub.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index feb4bb8ee3ec..4eadaef19e6a 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -675,7 +675,7 @@ static int sensor_hub_probe(struct hid_device *hdev,
 			       dev_cnt,
 			       sizeof(*sd->hid_sensor_hub_client_devs),
 			       GFP_KERNEL);
-	if (sd->hid_sensor_hub_client_devs == NULL) {
+	if (!sd->hid_sensor_hub_client_devs) {
 		ret = -ENOMEM;
 		goto err_stop_hw;
 	}
@@ -711,7 +711,7 @@ static int sensor_hub_probe(struct hid_device *hdev,
 			name = devm_kasprintf(&hdev->dev, GFP_KERNEL,
 					      "HID-SENSOR-%x",
 					      collection->usage);
-			if (name == NULL) {
+			if (!name) {
 				hid_err(hdev, "Failed MFD device name\n");
 				ret = -ENOMEM;
 				goto err_stop_hw;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] HID: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 3/7] HID: sensor-hub: Adjust two checks for null pointers in  sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 1/7] HID: sensor-hub: Use devm_kcalloc() in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 2/7] HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
    Re: HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 20:20 +0200
  [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
    Re: [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() Bruno Prémont <bonbons@linux-vserver.org> - 2017-04-25 09:00 +0200
  [PATCH 5/7] HID: debug: Replace 12 seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 6/7] HID: debug: Combine two seq_printf() calls into one call  in hid_dump_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 4/7] HID: debug: Replace five seq_printf() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200

csiph-web