Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629981

[PATCH 6/7] HID: debug: Combine two seq_printf() calls into one call in hid_dump_device()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 24 Apr 2017 21:07:52 +0200

A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/hid/hid-debug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index ce850f80d9e3..1e8ac6e569a2 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -646,8 +646,7 @@ void hid_dump_device(struct hid_device *device, struct seq_file *f)
 			seq_printf(f, "%s", table[i]);
 			if (report->id)
 				seq_printf(f, "(%d)", report->id);
-			seq_printf(f, "[%s]", table[report->type]);
-			seq_printf(f, "\n");
+			seq_printf(f, "[%s]\n", table[report->type]);
 			for (k = 0; k < report->maxfield; k++) {
 				tab(4, f);
 				seq_printf(f, "Field(%d)\n", k);
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] HID: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 3/7] HID: sensor-hub: Adjust two checks for null pointers in  sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 1/7] HID: sensor-hub: Use devm_kcalloc() in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 2/7] HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
    Re: HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 20:20 +0200
  [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
    Re: [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() Bruno Prémont <bonbons@linux-vserver.org> - 2017-04-25 09:00 +0200
  [PATCH 5/7] HID: debug: Replace 12 seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 6/7] HID: debug: Combine two seq_printf() calls into one call  in hid_dump_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 4/7] HID: debug: Replace five seq_printf() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200

csiph-web