Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629971

[PATCH 1/7] HID: sensor-hub: Use devm_kcalloc() in sensor_hub_probe()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 24 Apr 2017 19:25:29 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/hid/hid-sensor-hub.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 4ef73374a8f9..349494fc8def 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -672,9 +672,11 @@ static int sensor_hub_probe(struct hid_device *hdev,
 		ret = -EINVAL;
 		goto err_stop_hw;
 	}
-	sd->hid_sensor_hub_client_devs = devm_kzalloc(&hdev->dev, dev_cnt *
-						      sizeof(struct mfd_cell),
-						      GFP_KERNEL);
+	sd->hid_sensor_hub_client_devs
+		= devm_kcalloc(&hdev->dev,
+			       dev_cnt,
+			       sizeof(*sd->hid_sensor_hub_client_devs),
+			       GFP_KERNEL);
 	if (sd->hid_sensor_hub_client_devs == NULL) {
 		hid_err(hdev, "Failed to allocate memory for mfd cells\n");
 		ret = -ENOMEM;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] HID: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 3/7] HID: sensor-hub: Adjust two checks for null pointers in  sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 1/7] HID: sensor-hub: Use devm_kcalloc() in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
  [PATCH 2/7] HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:20 +0200
    Re: HID: sensor-hub: Delete error messages for failed memory  allocations in sensor_hub_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-27 20:20 +0200
  [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
    Re: [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by  seq_puts() in picolcd_debug_reset_show() Bruno Prémont <bonbons@linux-vserver.org> - 2017-04-25 09:00 +0200
  [PATCH 5/7] HID: debug: Replace 12 seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 6/7] HID: debug: Combine two seq_printf() calls into one call  in hid_dump_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200
  [PATCH 4/7] HID: debug: Replace five seq_printf() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 22:30 +0200

csiph-web