Re: selinux: Delete an error message for a failed memory allocation in policydb_read()

From	Paul Moore <paul@paul-moore.com>
Newsgroups	linux.kernel
Subject	Re: selinux: Delete an error message for a failed memory allocation in policydb_read()
Date	2017-03-27 20:40 +0200
Message-ID	<tpHIB-3SI-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <sZUBs-41H-17@gated-at.bofh.it> <toiCB-8g8-13@gated-at.bofh.it> <towme-1pZ-3@gated-at.bofh.it> <toW6Z-2QM-7@gated-at.bofh.it> <tpw0N-3AA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 27, 2017 at 1:56 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> …, but I like the error message.
>
> How do you think about to pass the flag “__GFP_NOWARN” if you like
> this information more than the default error reporting of the function “kmalloc”?

Possibly, although I would encourage you to just leave it as-is for
the moment.  Reviewing and merging patches carries a cost, and I would
very much prefer to allocate my time/resources on changes that have a
more significant impact.  I don't want to discourage your from
contributing to SELinux development, but I do want to strongly
encourage you to contribute more meaningful patches.

-- 
paul moore
www.paul-moore.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/46] selinux: Delete an error message for a failed  memory allocation in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-23 22:40 +0100
  Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-24 13:20 +0100
    Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-25 16:50 +0100
      Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-27 08:10 +0200
        Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-27 20:40 +0200

csiph-web