Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1608366

Re: selinux: Delete an error message for a failed memory allocation in policydb_read()

Show all headers | View raw

>> Omit an extra message for a memory allocation failure in this function.
>>
>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>  security/selinux/ss/policydb.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> I'm not going to remove an error message without some better reasoning
> in the patch description.  Providing a link to slides is fine, but
> your commit message needs to convey the important information and I
> don't think that is the case here (what happens when that URL dies?).

Do you need an explicit reminder there that the function “kmalloc” provides its own
error reporting already because the flag “__GFP_NOWARN” was not passed here?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/46] selinux: Delete an error message for a failed  memory allocation in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-23 22:40 +0100
  Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-24 13:20 +0100
    Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-25 16:50 +0100
      Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-27 08:10 +0200

csiph-web