Re: selinux: Delete an error message for a failed memory allocation in policydb_read()

Path	csiph.com!news.redatomik.org!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Paul Moore <paul@paul-moore.com>
Newsgroups	linux.kernel
Subject	Re: selinux: Delete an error message for a failed memory allocation in policydb_read()
Date	Mon, 27 Mar 2017 20:40:01 +0200
Message-ID	<tpHIB-3SI-11@gated-at.bofh.it> (permalink)
References	<sZUrL-3Jh-9@gated-at.bofh.it> <sZUBs-41H-17@gated-at.bofh.it> <toiCB-8g8-13@gated-at.bofh.it> <towme-1pZ-3@gated-at.bofh.it> <toW6Z-2QM-7@gated-at.bofh.it> <tpw0N-3AA-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MrjxW870lXV0qnd4maSRCIVCHKOILLgddeabyhg0xhE=; b=b63IBhbt7BQsYWzFV3gQqkNdfIhEvVBYdt8u5FxHt7ZSbcmCRs3vpC3GLi7rANMb4W biHlUU3Z6K0nHjZo/3+RncqKAx0g8Ht6het5ujiRNjcafwoIqQmpaMDxmnQ5SW5RHe2t NWyMAkaZhxlrf59aUd1HCtyAwNxVDjyD0rKLIh3H0HrOd0ZnNB8EHBQBU9Dg7fKLT1WD m/6qaqwXnD7ZiOeH2GbjhEJqWUf1xO2lvsDccRwfSSCZX7BfowLpJtO8OmulpyYyG8tR ksgGigypwerOeu2eVto6mCTChN2nweXmKSxMFqdzPS28zsg0EeP1ZtEUC/c2UcGKN8zG zSVA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MrjxW870lXV0qnd4maSRCIVCHKOILLgddeabyhg0xhE=; b=NMvfkJU5cuoPxMC00MNJFq76ME48ymqMClPnA9qFW3QxqyO8chIbDdza2R6Z0jAWow Lkk35LRkm6lRzDggib/FynPDU8vq7mitvZyE6Esltu82MiCF2GWC5lTllCeHb4iQT2Is sE/q1wmQBeHcUsglzUTNTZbgFyN9VKiC9P0VZ10awPAEY58e82301j0kA+CxnMb1IfnS ZZJHv4wJc/a+ikFW+Pm5xlrcgb7QFIskIzhfTOrncoGJaS+wDNBo1mnJ/aVnY53niSQ4 EGggkEz4SGpyrV+9mlRT/NKJz2F3d7kAS9sPIjCU7t9Ly/W7injsYkzsgDKaeGWA7eMZ EsbA==
X-Gm-Message-State	AFeK/H1puIlXiYl/oSPgQVtI7079WPLkW7sIAV3NoeERVZGW+4pnz+TGFW4hFMkMYIwMCsPAepUq++HkOoGW9A==
X-Received	by 10.31.62.6 with SMTP id l6mr8941199vka.74.1490639027826; Mon, 27 Mar 2017 11:23:47 -0700 (PDT)
MIME-Version	1.0
X-Originating-IP	[108.49.102.27]
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	quoted-printable
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris <eparis@parisplace.org>, James Morris <james.l.morris@oracle.com>, "Serge E. Hallyn" <serge@hallyn.com>, Stephen Smalley <sds@tycho.nsa.gov>, William Roberts <william.c.roberts@intel.com>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
X-Original-Date	Mon, 27 Mar 2017 14:23:47 -0400
X-Original-Message-ID	<CAHC9VhS81-9mFw8Eft8wf6C9MyDVGe8eB3Xvu8884-==5+H4mw@mail.gmail.com>
X-Original-References	<ca34123f-ced6-d2bc-363b-690858618827@users.sourceforge.net> <c589a851-2bf6-c44f-1df7-11f242285a73@users.sourceforge.net> <CAHC9VhTf6LdUNJHV9G+YA=P1rj78v5WKG8v+QNoFGZ6DA+mDmQ@mail.gmail.com> <ecce7c5c-cbeb-5896-ec12-26c97619c102@users.sourceforge.net> <CAHC9VhTOnQ5uJtb16CuNtsvOOg3C4k1H6fm8ytWJRKc45K=eNw@mail.gmail.com> <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610061

Show key headers only | View raw

On Mon, Mar 27, 2017 at 1:56 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> …, but I like the error message.
>
> How do you think about to pass the flag “__GFP_NOWARN” if you like
> this information more than the default error reporting of the function “kmalloc”?

Possibly, although I would encourage you to just leave it as-is for
the moment.  Reviewing and merging patches carries a cost, and I would
very much prefer to allocate my time/resources on changes that have a
more significant impact.  I don't want to discourage your from
contributing to SELinux development, but I do want to strongly
encourage you to contribute more meaningful patches.

-- 
paul moore
www.paul-moore.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/46] selinux: Delete an error message for a failed  memory allocation in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-23 22:40 +0100
  Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-24 13:20 +0100
    Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-25 16:50 +0100
      Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-27 08:10 +0200
        Re: selinux: Delete an error message for a failed memory allocation  in policydb_read() Paul Moore <paul@paul-moore.com> - 2017-03-27 20:40 +0200

csiph-web