Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies
Date	2017-03-23 16:00 +0100
Message-ID	<tocnw-3Ak-25@gated-at.bofh.it> (permalink)
References	<tnCal-2uo-5@gated-at.bofh.it> <tnKKC-aT-5@gated-at.bofh.it> <tnQQ3-4OP-57@gated-at.bofh.it> <tnZqh-36m-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Sebastian Reichel <sre@kernel.org> [170322 18:02]:
> Hi,
> 
> On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> > > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > > This fixes compilation for files, that try to include the
> > > > cpcap header in alphabetically sorted #include lists.
> > > > 
> > > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > > 
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Hmm I wonder why I never ran into this so far. No objections
> > to the patch though if it fixes the issue with all the necessary
> > headers included.
> 
> Because you usually sort includes differently moving headers
> from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
> device.h will already be included when the compiler includes
> motorola-cpcap.h.

Ah OK yeah I do that usually. Your patch seems OK to me:

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-22 01:20 +0100
  Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:30 +0100
    Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-22 17:00 +0100
      Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-23 02:10 +0100
        Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-23 16:00 +0100

csiph-web