Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606694
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies |
| Date | 2017-03-22 17:00 +0100 |
| Message-ID | <tnQQ3-4OP-57@gated-at.bofh.it> (permalink) |
| References | <tnCal-2uo-5@gated-at.bofh.it> <tnKKC-aT-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Pavel Machek <pavel@ucw.cz> [170322 02:29]: > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote: > > This fixes compilation for files, that try to include the > > cpcap header in alphabetically sorted #include lists. > > > > Signed-off-by: Sebastian Reichel <sre@kernel.org> > > Acked-by: Pavel Machek <pavel@ucw.cz> Hmm I wonder why I never ran into this so far. No objections to the patch though if it fixes the issue with all the necessary headers included. Regards, Tony > > --- > > This patch is new, since PATCHv1 did not order the includes > > in the led driver alphabetically. > > --- > > include/linux/mfd/motorola-cpcap.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h > > index 7629e0d24d26..b8916953a537 100644 > > --- a/include/linux/mfd/motorola-cpcap.h > > +++ b/include/linux/mfd/motorola-cpcap.h > > @@ -14,6 +14,9 @@ > > * published by the Free Software Foundation. > > */ > > > > +#include <linux/device.h> > > +#include <linux/regmap.h> > > + > > #define CPCAP_VENDOR_ST 0 > > #define CPCAP_VENDOR_TI 1 > > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-22 01:20 +0100
Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:30 +0100
Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-22 17:00 +0100
Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-23 02:10 +0100
Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-23 16:00 +0100
csiph-web