Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies
Date	Thu, 23 Mar 2017 16:00:02 +0100
Message-ID	<tocnw-3Ak-25@gated-at.bofh.it> (permalink)
References	<tnCal-2uo-5@gated-at.bofh.it> <tnKKC-aT-5@gated-at.bofh.it> <tnQQ3-4OP-57@gated-at.bofh.it> <tnZqh-36m-7@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
Content-Transfer-Encoding	8BIT
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Pavel Machek <pavel@ucw.cz>, Richard Purdie <rpurdie@rpsys.net>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 23 Mar 2017 07:52:15 -0700
X-Original-Message-ID	<20170323145215.GK10760@atomide.com>
X-Original-References	<20170322000912.24210-1-sre@kernel.org> <20170322092708.GA26771@amd> <20170322155716.GC10760@atomide.com> <20170323010005.xc3phqrimdcrbti4@earth>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1607569

Show key headers only | View raw

* Sebastian Reichel <sre@kernel.org> [170322 18:02]:
> Hi,
> 
> On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> > > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > > This fixes compilation for files, that try to include the
> > > > cpcap header in alphabetically sorted #include lists.
> > > > 
> > > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > > 
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Hmm I wonder why I never ran into this so far. No objections
> > to the patch though if it fixes the issue with all the necessary
> > headers included.
> 
> Because you usually sort includes differently moving headers
> from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
> device.h will already be included when the compiler includes
> motorola-cpcap.h.

Ah OK yeah I do that usually. Your patch seems OK to me:

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-22 01:20 +0100
  Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:30 +0100
    Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-22 17:00 +0100
      Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-23 02:10 +0100
        Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-23 16:00 +0100

csiph-web