Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603110

Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation

Show all headers | View raw

* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> Hi,
> 
> The patcheset generalize mm/gup.c implementation of get_user_pages_fast()
> to be usable for x86 and switches x86 over.
> 
> Please review and consider applying.
> 
> Kirill A. Shutemov (7):
>   mm: Drop arch_pte_access_permitted() mmu hook
>   mm/gup: Move permission checks into helpers
>   mm/gup: Move page table entry dereference into helper
>   mm/gup: Make pages referenced during generic get_user_pages_fast()
>   mm/gup: Implement dev_pagemap logic in generic get_user_pages_fast()
>   mm/gup: Provide hook to check if __GUP_fast() is allowed for the range
>   x86/mm: Switch to generic get_user_page_fast() implementation
> 
>  arch/powerpc/include/asm/mmu_context.h   |   6 -
>  arch/s390/include/asm/mmu_context.h      |   6 -
>  arch/um/include/asm/mmu_context.h        |   6 -
>  arch/unicore32/include/asm/mmu_context.h |   6 -
>  arch/x86/Kconfig                         |   3 +
>  arch/x86/include/asm/mmu_context.h       |  16 -
>  arch/x86/include/asm/pgtable-3level.h    |  45 +++
>  arch/x86/include/asm/pgtable.h           |  53 ++++
>  arch/x86/include/asm/pgtable_64.h        |  16 +-
>  arch/x86/mm/Makefile                     |   2 +-
>  arch/x86/mm/gup.c                        | 496 -------------------------------
>  include/asm-generic/mm_hooks.h           |   6 -
>  include/asm-generic/pgtable.h            |  25 ++
>  include/linux/mm.h                       |   4 +
>  mm/gup.c                                 | 134 +++++++--
>  15 files changed, 262 insertions(+), 562 deletions(-)
>  delete mode 100644 arch/x86/mm/gup.c

It fails to build on x86-64 defconfig/allyesconfig/allmodconfig:

  mm/gup.c:1422:15: error: implicit declaration of function ‘pgd_devmap’ [-Werror=implicit-function-declaration]

The PowerPC allnoconfig build broke as well:

/home/mingo/tip/mm/gup.c: In function '__gup_device_huge_pmd':
/home/mingo/tip/mm/gup.c:1319:2: error: implicit declaration of function 'pmd_pfn' [-Werror=implicit-function-declaration]

Please send delta fixes, because I've already done many small readability edits to 
the patches.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
  [PATCH 3/7] mm/gup: Move page table entry dereference into helper "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Move page table entry dereference into helper  function "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 4/7] mm/gup: Make pages referenced during generic get_user_pages_fast() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Mark all pages PageReferenced in generic  get_user_pages_fast() "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation Peter Zijlstra <peterz@infradead.org> - 2017-03-16 18:30 +0100
      Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-03-16 20:20 +0100
    [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 22:40 +0100
      Re: [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-17 18:40 +0100
      [tip:x86/mm] x86/mm/gup: Switch GUP to the generic  get_user_page_fast() implementation "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 12:50 +0100
  [PATCH 1/7] mm: Drop arch_pte_access_permitted() mmu hook "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:40 +0100
    [tip:x86/mm] mm/gup: Drop the arch_pte_access_permitted() MMU  callback "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:10 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast()  implementation Ingo Molnar <mingo@kernel.org> - 2017-03-17 09:40 +0100

csiph-web