Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602551

[PATCH 1/7] mm: Drop arch_pte_access_permitted() mmu hook

From "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH 1/7] mm: Drop arch_pte_access_permitted() mmu hook
Date 2017-03-16 16:40 +0100
Message-ID <tlFFo-lI-25@gated-at.bofh.it> (permalink)
References <tlFvH-gv-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

The only arch that defines it to something meaningful is x86.
But x86 doesn't use generic GUP_fast() implementation -- the only place
where the hook is called.

Let's drop it.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 arch/powerpc/include/asm/mmu_context.h   | 6 ------
 arch/s390/include/asm/mmu_context.h      | 6 ------
 arch/um/include/asm/mmu_context.h        | 6 ------
 arch/unicore32/include/asm/mmu_context.h | 6 ------
 arch/x86/include/asm/mmu_context.h       | 4 ----
 include/asm-generic/mm_hooks.h           | 6 ------
 mm/gup.c                                 | 3 ---
 7 files changed, 37 deletions(-)

diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h
index b9e3f0aca261..ecf9885ab660 100644
--- a/arch/powerpc/include/asm/mmu_context.h
+++ b/arch/powerpc/include/asm/mmu_context.h
@@ -163,11 +163,5 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	/* by default, allow everything */
 	return true;
 }
-
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	/* by default, allow everything */
-	return true;
-}
 #endif /* __KERNEL__ */
 #endif /* __ASM_POWERPC_MMU_CONTEXT_H */
diff --git a/arch/s390/include/asm/mmu_context.h b/arch/s390/include/asm/mmu_context.h
index 6e31d87fb669..fa2bf69be182 100644
--- a/arch/s390/include/asm/mmu_context.h
+++ b/arch/s390/include/asm/mmu_context.h
@@ -156,10 +156,4 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	/* by default, allow everything */
 	return true;
 }
-
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	/* by default, allow everything */
-	return true;
-}
 #endif /* __S390_MMU_CONTEXT_H */
diff --git a/arch/um/include/asm/mmu_context.h b/arch/um/include/asm/mmu_context.h
index 94ac2739918c..b668e351fd6c 100644
--- a/arch/um/include/asm/mmu_context.h
+++ b/arch/um/include/asm/mmu_context.h
@@ -37,12 +37,6 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	return true;
 }
 
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	/* by default, allow everything */
-	return true;
-}
-
 /*
  * end asm-generic/mm_hooks.h functions
  */
diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
index 62dfc644c908..59b06b48f27d 100644
--- a/arch/unicore32/include/asm/mmu_context.h
+++ b/arch/unicore32/include/asm/mmu_context.h
@@ -103,10 +103,4 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	/* by default, allow everything */
 	return true;
 }
-
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	/* by default, allow everything */
-	return true;
-}
 #endif
diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h
index 306c7e12af55..68b329d77b3a 100644
--- a/arch/x86/include/asm/mmu_context.h
+++ b/arch/x86/include/asm/mmu_context.h
@@ -268,8 +268,4 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	return __pkru_allows_pkey(vma_pkey(vma), write);
 }
 
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	return __pkru_allows_pkey(pte_flags_pkey(pte_flags(pte)), write);
-}
 #endif /* _ASM_X86_MMU_CONTEXT_H */
diff --git a/include/asm-generic/mm_hooks.h b/include/asm-generic/mm_hooks.h
index cc5d9a1405df..41e5b6784b97 100644
--- a/include/asm-generic/mm_hooks.h
+++ b/include/asm-generic/mm_hooks.h
@@ -32,10 +32,4 @@ static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
 	/* by default, allow everything */
 	return true;
 }
-
-static inline bool arch_pte_access_permitted(pte_t pte, bool write)
-{
-	/* by default, allow everything */
-	return true;
-}
 #endif	/* _ASM_GENERIC_MM_HOOKS_H */
diff --git a/mm/gup.c b/mm/gup.c
index 04aa405350dc..3f2338ba3402 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1216,9 +1216,6 @@ static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end,
 			pte_protnone(pte) || (write && !pte_write(pte)))
 			goto pte_unmap;
 
-		if (!arch_pte_access_permitted(pte, write))
-			goto pte_unmap;
-
 		VM_BUG_ON(!pfn_valid(pte_pfn(pte)));
 		page = pte_page(pte);
 		head = compound_head(page);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
  [PATCH 3/7] mm/gup: Move page table entry dereference into helper "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Move page table entry dereference into helper  function "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 4/7] mm/gup: Make pages referenced during generic get_user_pages_fast() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Mark all pages PageReferenced in generic  get_user_pages_fast() "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation Peter Zijlstra <peterz@infradead.org> - 2017-03-16 18:30 +0100
      Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-03-16 20:20 +0100
    [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 22:40 +0100
      Re: [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-17 18:40 +0100
      [tip:x86/mm] x86/mm/gup: Switch GUP to the generic  get_user_page_fast() implementation "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 12:50 +0100
  [PATCH 1/7] mm: Drop arch_pte_access_permitted() mmu hook "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:40 +0100
    [tip:x86/mm] mm/gup: Drop the arch_pte_access_permitted() MMU  callback "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:10 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast()  implementation Ingo Molnar <mingo@kernel.org> - 2017-03-17 09:40 +0100

csiph-web