Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602543

[PATCH 4/7] mm/gup: Make pages referenced during generic get_user_pages_fast()

Show all headers | View raw

This is preparation patch for transition of x86 to generic GUP_fast()
implementation.

Unlike generic GUP_fast(), x86 version makes all pages it touches
referenced. It seems required for GRU and EPT.

See commit 8ee53820edfd ("thp: mmu_notifier_test_young").

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
---
 mm/gup.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/mm/gup.c b/mm/gup.c
index ed2259dc4606..f0cfe225c08f 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1238,6 +1238,8 @@ static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end,
 		}
 
 		VM_BUG_ON_PAGE(compound_head(page) != head, page);
+
+		SetPageReferenced(page);
 		pages[*nr] = page;
 		(*nr)++;
 
@@ -1299,6 +1301,7 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr,
 		return 0;
 	}
 
+	SetPageReferenced(head);
 	return 1;
 }
 
@@ -1334,6 +1337,7 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr,
 		return 0;
 	}
 
+	SetPageReferenced(head);
 	return 1;
 }
 
@@ -1370,6 +1374,7 @@ static int gup_huge_pgd(pgd_t orig, pgd_t *pgdp, unsigned long addr,
 		return 0;
 	}
 
+	SetPageReferenced(head);
 	return 1;
 }
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
  [PATCH 3/7] mm/gup: Move page table entry dereference into helper "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Move page table entry dereference into helper  function "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 4/7] mm/gup: Make pages referenced during generic get_user_pages_fast() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    [tip:x86/mm] mm/gup: Mark all pages PageReferenced in generic  get_user_pages_fast() "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:30 +0100
    Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation Peter Zijlstra <peterz@infradead.org> - 2017-03-16 18:30 +0100
      Re: [PATCH 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-03-16 20:20 +0100
    [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast() implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 22:40 +0100
      Re: [PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast()  implementation "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-17 18:40 +0100
      [tip:x86/mm] x86/mm/gup: Switch GUP to the generic  get_user_page_fast() implementation "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 12:50 +0100
  [PATCH 1/7] mm: Drop arch_pte_access_permitted() mmu hook "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-16 16:40 +0100
    [tip:x86/mm] mm/gup: Drop the arch_pte_access_permitted() MMU  callback "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-03-18 11:00 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast() implementation Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:10 +0100
  Re: [PATCH 0/7] Switch x86 to generic get_user_pages_fast()  implementation Ingo Molnar <mingo@kernel.org> - 2017-03-17 09:40 +0100

csiph-web