Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600921
| From | "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] firmware: ti_sci: fix strncat length check |
| Date | 2017-03-14 22:30 +0100 |
| Message-ID | <tl2b0-66f-29@gated-at.bofh.it> (permalink) |
| References | <tl21k-62z-11@gated-at.bofh.it> |
| Organization | Oracle Corporation |
On 3/14/17 2:11 PM, Arnd Bergmann wrote:
> gcc-7 notices that the length we pass to strncat is wrong:
>
> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=]
>
> Instead of the total length, we must pass the length of the
> remaining space here.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Acked-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.
Looks fine to me Arnd. Will you be applying it to SOC driver branch ?
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] firmware: ti_sci: fix strncat length check Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:20 +0100 Re: [PATCH] firmware: ti_sci: fix strncat length check "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2017-03-14 22:30 +0100
csiph-web