[PATCH] net: sun: sungem: rix a possible null dereference

From	Philippe Reynes <tremyfr@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: sun: sungem: rix a possible null dereference
Date	2017-03-14 22:30 +0100
Message-ID	<tl2b1-66f-41@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The function gem_begin_auto_negotiation dereference
the pointer ep before testing if it's null. This
patch add a check on ep before dereferencing it.

This issue was added by the patch 92552fdd557:
"net: sun: sungem: use new api ethtool_{get|set}_link_ksettings".

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
 drivers/net/ethernet/sun/sungem.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index dbfca04..fa607d0 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -1259,8 +1259,9 @@ static void gem_begin_auto_negotiation(struct gem *gp,
 	int duplex;
 	u32 advertising;
 
-	ethtool_convert_link_mode_to_legacy_u32(&advertising,
-						ep->link_modes.advertising);
+	if (ep)
+		ethtool_convert_link_mode_to_legacy_u32(
+			&advertising, ep->link_modes.advertising);
 
 	if (gp->phy_type != phy_mii_mdio0 &&
      	    gp->phy_type != phy_mii_mdio1)
-- 
1.7.4.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-14 22:30 +0100
  Re: [PATCH] net: sun: sungem: rix a possible null dereference Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-15 11:10 +0100
    Re: [PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-15 22:50 +0100

csiph-web