Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600921
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] firmware: ti_sci: fix strncat length check |
| Date | Tue, 14 Mar 2017 22:30:02 +0100 |
| Message-ID | <tl2b0-66f-29@gated-at.bofh.it> (permalink) |
| References | <tl21k-62z-11@gated-at.bofh.it> |
| Organization | Oracle Corporation |
| User-Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252; format=flowed |
| Content-Transfer-Encoding | 7bit |
| X-Source-IP | aserv0021.oracle.com [141.146.126.233] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 18 |
| X-Original-Cc | Dave Gerlach <d-gerlach@ti.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 14 Mar 2017 14:19:18 -0700 |
| X-Original-Message-ID | <4e3a448e-da7e-4da5-96bf-327da2a8c7d0@oracle.com> |
| X-Original-References | <20170314211157.3424031-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1600921 |
Show key headers only | View raw
On 3/14/17 2:11 PM, Arnd Bergmann wrote:
> gcc-7 notices that the length we pass to strncat is wrong:
>
> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=]
>
> Instead of the total length, we must pass the length of the
> remaining space here.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Acked-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.
Looks fine to me Arnd. Will you be applying it to SOC driver branch ?
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] firmware: ti_sci: fix strncat length check Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:20 +0100 Re: [PATCH] firmware: ti_sci: fix strncat length check "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2017-03-14 22:30 +0100
csiph-web